[GitHub] [apisix] ShiningRush commented on a change in pull request #2331: fix(basic-auth): split schema to adapt different occasions

[GitBox <gi...@apache.org>]

ShiningRush commented on a change in pull request #2331:
URL: https://github.com/apache/apisix/pull/2331#discussion_r495713121



##########
File path: apisix/core/schema.lua
##########
@@ -20,7 +20,11 @@ local lrucache = require("apisix.core.lrucache")
 local cached_validator = lrucache.new({count = 1000, ttl = 0})
 local pcall = pcall
 
-local _M = {version = 0.3}
+local _M = {
+    version = 0.3,
+    TYPE_ANY = 1,

Review comment:
       - `TYPE_ANY` is confused, I think `TYPE_CONF` or `TYPE_OPT` would be better, how do you think?
   - It seems like the code of checking plugin's config does not using this parameter, are there any special considerations?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org