[GitHub] [hudi] the-other-tim-brown commented on a diff in pull request #7096: [MINOR] Fix OverwriteWithLatestAvroPayload full class name

[GitBox <gi...@apache.org>]

the-other-tim-brown commented on code in PR #7096:
URL: https://github.com/apache/hudi/pull/7096#discussion_r1009944491


##########
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/realtime/AbstractRealtimeRecordReader.java:
##########
@@ -85,7 +85,7 @@ public AbstractRealtimeRecordReader(RealtimeSplit split, JobConf job) {
 
   private boolean usesCustomPayload(HoodieTableMetaClient metaClient) {
     return !(metaClient.getTableConfig().getPayloadClass().contains(HoodieAvroPayload.class.getName())
-        || metaClient.getTableConfig().getPayloadClass().contains("org.apache.hudi.OverwriteWithLatestAvroPayload"));
+        || metaClient.getTableConfig().getPayloadClass().contains("org.apache.hudi.common.model.OverwriteWithLatestAvroPayload"));

Review Comment:
   Can we use `OverwriteWithLatestAvroPayload.class.getName()` to avoid potential typos and so it will be updated if the location of the class changes?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org