[PR] Support parsing Doris ADMIN SET REPLICA STATUS/VERSION and ADMIN COPY TABLET syntax [shardingsphere]

["ccxxxyy (via GitHub)" <gi...@apache.org>]

ccxxxyy opened a new pull request, #38349:
URL: https://github.com/apache/shardingsphere/pull/38349

   for https://github.com/apache/shardingsphere/issues/31467
   
   Changes proposed in this pull request:
     -
   
   ---
   
   Before committing this PR, I'm sure that I have checked the following options:
   - [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
   - [x] I have self-reviewed the commit code.
   - [ ] I have (or in comment I request) added corresponding labels for the pull request.
   - [x] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
   - [ ] I have made corresponding changes to the documentation.
   - [ ] I have added corresponding unit tests for my changes.
   - [ ] I have updated the Release Notes of the current development version. For more details, see [Update Release Note](https://shardingsphere.apache.org/community/en/involved/contribute/contributor/)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Support parsing Doris ADMIN SET REPLICA STATUS/VERSION and ADMIN COPY TABLET syntax [shardingsphere]

["terrymanu (via GitHub)" <gi...@apache.org>]

terrymanu merged PR #38349:
URL: https://github.com/apache/shardingsphere/pull/38349


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Support parsing Doris ADMIN SET REPLICA STATUS/VERSION and ADMIN COPY TABLET syntax [shardingsphere]

["ccxxxyy (via GitHub)" <gi...@apache.org>]

ccxxxyy commented on PR #38349:
URL: https://github.com/apache/shardingsphere/pull/38349#issuecomment-3998425920

   Regarding **TABLET**, Doris treat it as reserved keyword.
   Regarding **VERSION**, [Doris ](https://doris.apache.org/docs/4.x/sql-manual/basic-element/reserved-keywords)does not treat it as reserved keyword. Therefore, I have added it to `identifierKeywordsUnambiguous` in `BaseRule.g4`, so that it can be used in places where identifiers are expected.
   
   My reasoning is as follows:
   
   The identifier usage chain is:
   
   tableName → name → identifier
   columnName → identifier
   
   and identifier includes identifierKeywordsUnambiguous.
   
   This means that the keyword can be used as identifiers, such as table names, column names, and database names, without requiring quotation marks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org