[jira] [Commented] (ZOOKEEPER-2272) Code clean up in ZooKeeperServer and KerberosName

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15342916#comment-15342916 ] 

Hadoop QA commented on ZOOKEEPER-2272:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12755079/ZOOKEEPER-2272-01.patch
  against trunk revision 1748630.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    -1 patch.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3209//console

This message is automatically generated.

> Code clean up in ZooKeeperServer and KerberosName
> -------------------------------------------------
>
>                 Key: ZOOKEEPER-2272
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2272
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: server
>    Affects Versions: 3.5.0
>            Reporter: Arshad Mohammad
>            Assignee: Arshad Mohammad
>            Priority: Trivial
>             Fix For: 3.5.3
>
>         Attachments: ZOOKEEPER-2272-01.patch
>
>
> # Following code in {{org.apache.zookeeper.server.ZooKeeperServer}} should be cleaned up. Some how it got missed in code review
> {code}
> if ((System.getProperty("zookeeper.allowSaslFailedClients") != null)
>   &&  (System.getProperty("zookeeper.allowSaslFailedClients").equals("true"))) {
> {code}
> should be replaced with 
> {code}
> if(Boolean.getBoolean("zookeeper.allowSaslFailedClients"))
> {code}
> # Similar code clean up can be done in {{org.apache.zookeeper.server.auth.KerberosName}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)