You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tika.apache.org by ta...@apache.org on 2016/11/08 02:22:27 UTC

tika git commit: TIKA-1933 - clean up one more place where we aren't closing the ForkParser and are leaving behind a tmp ForkParser jar

Repository: tika
Updated Branches:
  refs/heads/2.x 2d5189186 -> 1d1bc0dd7


TIKA-1933 - clean up one more place where we aren't closing the ForkParser and are leaving behind a tmp ForkParser jar


Project: http://git-wip-us.apache.org/repos/asf/tika/repo
Commit: http://git-wip-us.apache.org/repos/asf/tika/commit/1d1bc0dd
Tree: http://git-wip-us.apache.org/repos/asf/tika/tree/1d1bc0dd
Diff: http://git-wip-us.apache.org/repos/asf/tika/diff/1d1bc0dd

Branch: refs/heads/2.x
Commit: 1d1bc0dd7a145651f62bd93b363b0247035f1c00
Parents: 2d51891
Author: tballison <ta...@mitre.org>
Authored: Mon Nov 7 21:22:21 2016 -0500
Committer: tballison <ta...@mitre.org>
Committed: Mon Nov 7 21:22:21 2016 -0500

----------------------------------------------------------------------
 .../org/apache/tika/parser/fork/ForkParserIntegrationTest.java   | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/tika/blob/1d1bc0dd/tika-app/src/test/java/org/apache/tika/parser/fork/ForkParserIntegrationTest.java
----------------------------------------------------------------------
diff --git a/tika-app/src/test/java/org/apache/tika/parser/fork/ForkParserIntegrationTest.java b/tika-app/src/test/java/org/apache/tika/parser/fork/ForkParserIntegrationTest.java
index 54c1427..6a7739c 100644
--- a/tika-app/src/test/java/org/apache/tika/parser/fork/ForkParserIntegrationTest.java
+++ b/tika-app/src/test/java/org/apache/tika/parser/fork/ForkParserIntegrationTest.java
@@ -151,7 +151,7 @@ public class ForkParserIntegrationTest {
     @Test
     public void testParsingErrorInForkedParserShouldBeReported() throws Exception {
         BrokenParser brokenParser = new BrokenParser();
-        Parser parser = new ForkParser(ForkParser.class.getClassLoader(), brokenParser);
+        ForkParser parser = new ForkParser(ForkParser.class.getClassLoader(), brokenParser);
         InputStream stream = getClass().getResourceAsStream("/test-documents/testTXT.txt");
         
         // With a serializable error, we'll get that back
@@ -162,6 +162,8 @@ public class ForkParserIntegrationTest {
             fail("Expected TikaException caused by Error");
         } catch (TikaException e) {
             assertEquals(brokenParser.err, e.getCause());
+        } finally {
+            parser.close();
         }
         
         // With a non serializable one, we'll get something else