You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Guangya Liu <gy...@gmail.com> on 2015/09/19 02:42:52 UTC
Review Request 38516: Changed quiesceOffers to SuppressOffers
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38516/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Bugs: MESOS-3037
https://issues.apache.org/jira/browse/MESOS-3037
Repository: mesos
Description
-------
A comment from Vinod: After some discussion with other committers,
most of them felt suppressOffers is better than quiesceOffers.
Diffs
-----
include/mesos/master/allocator.hpp 2dc631242bca8d5e1d536126770f5bcbab2fefed
include/mesos/scheduler.hpp 071f448153080bfcc967755157cf900994947484
src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp d8acc4fe92fc8dfbd582b165fba24dac492c28d4
src/java/src/org/apache/mesos/MesosSchedulerDriver.java de88463da2f6833633542442a0d66370507c4018
src/java/src/org/apache/mesos/SchedulerDriver.java ba4bc58f57b01ad3705438e1172bf6663e2a2446
src/master/allocator/mesos/allocator.hpp 86f6c5572f831b19a3eb006456320df2a445df45
src/master/allocator/mesos/hierarchical.hpp 8f2232a13b6fa0cd01d0399460f9637858a8c6b8
src/master/master.cpp 64e5fb9e27b2e6797b2ce87c0e1a3ef8a2943e27
src/master/metrics.hpp a3c0c0c18047298179b6d09c4126fe594c0b4eaf
src/master/metrics.cpp 6bce80bace0c2ad01ec0b26de9ecbd401a597988
src/python/interface/src/mesos/interface/__init__.py cd60ead6c6519d7347aec1fd9315735af0fa818a
src/python/native/src/mesos/native/mesos_scheduler_driver_impl.hpp 04e3190949fba8e4675352636b0a649a033f702f
src/python/native/src/mesos/native/mesos_scheduler_driver_impl.cpp 10208b176c9b45d5c9afc096564e27403dcde695
src/sched/sched.cpp 84c2edb2c660f976fd57d1407dd2e9d5376500aa
src/tests/master_tests.cpp a044286d10bf1ab0676c7d403a5555f59e0b1fea
src/tests/mesos.hpp 760dcb7a224141d772098ccd1a7658b2d28f6e21
src/tests/metrics_tests.cpp 9b7f84a8c6b4f56f329577569041621a617aa0cb
src/tests/scheduler_tests.cpp 0f892f9d423f0bc72cdab22452e0ad7965dda444
Diff: https://reviews.apache.org/r/38516/diff/
Testing
-------
Thanks,
Guangya Liu
Re: Review Request 38516: Changed quiesceOffers to SuppressOffers
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38516/
-----------------------------------------------------------
(Updated 九月 21, 2015, 6:05 a.m.)
Review request for mesos and Vinod Kone.
Bugs: MESOS-3037
https://issues.apache.org/jira/browse/MESOS-3037
Repository: mesos
Description
-------
A comment from Vinod: After some discussion with other committers,
most of them felt suppressOffers is better than quiesceOffers.
Diffs (updated)
-----
include/mesos/master/allocator.hpp 3fea47ffcc69531308068e2701502e481605b912
include/mesos/scheduler.hpp 071f448153080bfcc967755157cf900994947484
src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp d8acc4fe92fc8dfbd582b165fba24dac492c28d4
src/java/src/org/apache/mesos/MesosSchedulerDriver.java de88463da2f6833633542442a0d66370507c4018
src/java/src/org/apache/mesos/SchedulerDriver.java ba4bc58f57b01ad3705438e1172bf6663e2a2446
src/master/allocator/mesos/allocator.hpp 904dc6220a1b722ca9c4582b91f98cad81eacc53
src/master/allocator/mesos/hierarchical.hpp d3496bcff6235adc3a6bb7de7b4c3d23d540cfa0
src/master/master.cpp 6c0db210747c7d88179556abaade65743bd8cb3a
src/master/metrics.hpp a3c0c0c18047298179b6d09c4126fe594c0b4eaf
src/master/metrics.cpp 6bce80bace0c2ad01ec0b26de9ecbd401a597988
src/python/interface/src/mesos/interface/__init__.py cd60ead6c6519d7347aec1fd9315735af0fa818a
src/python/native/src/mesos/native/mesos_scheduler_driver_impl.hpp 04e3190949fba8e4675352636b0a649a033f702f
src/python/native/src/mesos/native/mesos_scheduler_driver_impl.cpp 10208b176c9b45d5c9afc096564e27403dcde695
src/sched/sched.cpp 84c2edb2c660f976fd57d1407dd2e9d5376500aa
src/tests/master_tests.cpp a044286d10bf1ab0676c7d403a5555f59e0b1fea
src/tests/mesos.hpp e1c06352736c339e8cd336811134054617df1fc6
src/tests/metrics_tests.cpp 9b7f84a8c6b4f56f329577569041621a617aa0cb
src/tests/scheduler_tests.cpp 0f892f9d423f0bc72cdab22452e0ad7965dda444
Diff: https://reviews.apache.org/r/38516/diff/
Testing
-------
Platform: Ubuntu:14.04
make
make check
Thanks,
Guangya Liu
Re: Review Request 38516: Changed quiesceOffers to SuppressOffers
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38516/#review99717
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Sept. 21, 2015, 12:11 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38516/
> -----------------------------------------------------------
>
> (Updated Sept. 21, 2015, 12:11 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-3037
> https://issues.apache.org/jira/browse/MESOS-3037
>
>
> Repository: mesos
>
>
> Description
> -------
>
> A comment from Vinod: After some discussion with other committers,
> most of them felt suppressOffers is better than quiesceOffers.
>
>
> Diffs
> -----
>
> include/mesos/master/allocator.hpp 3fea47ffcc69531308068e2701502e481605b912
> include/mesos/scheduler.hpp 071f448153080bfcc967755157cf900994947484
> src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp d8acc4fe92fc8dfbd582b165fba24dac492c28d4
> src/java/src/org/apache/mesos/MesosSchedulerDriver.java de88463da2f6833633542442a0d66370507c4018
> src/java/src/org/apache/mesos/SchedulerDriver.java ba4bc58f57b01ad3705438e1172bf6663e2a2446
> src/master/allocator/mesos/allocator.hpp 904dc6220a1b722ca9c4582b91f98cad81eacc53
> src/master/allocator/mesos/hierarchical.hpp d3496bcff6235adc3a6bb7de7b4c3d23d540cfa0
> src/master/master.cpp 6c0db210747c7d88179556abaade65743bd8cb3a
> src/master/metrics.hpp a3c0c0c18047298179b6d09c4126fe594c0b4eaf
> src/master/metrics.cpp 6bce80bace0c2ad01ec0b26de9ecbd401a597988
> src/python/interface/src/mesos/interface/__init__.py cd60ead6c6519d7347aec1fd9315735af0fa818a
> src/python/native/src/mesos/native/mesos_scheduler_driver_impl.hpp 04e3190949fba8e4675352636b0a649a033f702f
> src/python/native/src/mesos/native/mesos_scheduler_driver_impl.cpp 10208b176c9b45d5c9afc096564e27403dcde695
> src/sched/sched.cpp 84c2edb2c660f976fd57d1407dd2e9d5376500aa
> src/tests/master_tests.cpp a044286d10bf1ab0676c7d403a5555f59e0b1fea
> src/tests/mesos.hpp e1c06352736c339e8cd336811134054617df1fc6
> src/tests/metrics_tests.cpp 9b7f84a8c6b4f56f329577569041621a617aa0cb
> src/tests/scheduler_tests.cpp 0f892f9d423f0bc72cdab22452e0ad7965dda444
>
> Diff: https://reviews.apache.org/r/38516/diff/
>
>
> Testing
> -------
>
> Platform: Ubuntu:14.04
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 38516: Changed quiesceOffers to SuppressOffers
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38516/
-----------------------------------------------------------
(Updated 九月 21, 2015, 12:11 a.m.)
Review request for mesos and Vinod Kone.
Changes
-------
rebase
Bugs: MESOS-3037
https://issues.apache.org/jira/browse/MESOS-3037
Repository: mesos
Description
-------
A comment from Vinod: After some discussion with other committers,
most of them felt suppressOffers is better than quiesceOffers.
Diffs (updated)
-----
include/mesos/master/allocator.hpp 3fea47ffcc69531308068e2701502e481605b912
include/mesos/scheduler.hpp 071f448153080bfcc967755157cf900994947484
src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp d8acc4fe92fc8dfbd582b165fba24dac492c28d4
src/java/src/org/apache/mesos/MesosSchedulerDriver.java de88463da2f6833633542442a0d66370507c4018
src/java/src/org/apache/mesos/SchedulerDriver.java ba4bc58f57b01ad3705438e1172bf6663e2a2446
src/master/allocator/mesos/allocator.hpp 904dc6220a1b722ca9c4582b91f98cad81eacc53
src/master/allocator/mesos/hierarchical.hpp d3496bcff6235adc3a6bb7de7b4c3d23d540cfa0
src/master/master.cpp 6c0db210747c7d88179556abaade65743bd8cb3a
src/master/metrics.hpp a3c0c0c18047298179b6d09c4126fe594c0b4eaf
src/master/metrics.cpp 6bce80bace0c2ad01ec0b26de9ecbd401a597988
src/python/interface/src/mesos/interface/__init__.py cd60ead6c6519d7347aec1fd9315735af0fa818a
src/python/native/src/mesos/native/mesos_scheduler_driver_impl.hpp 04e3190949fba8e4675352636b0a649a033f702f
src/python/native/src/mesos/native/mesos_scheduler_driver_impl.cpp 10208b176c9b45d5c9afc096564e27403dcde695
src/sched/sched.cpp 84c2edb2c660f976fd57d1407dd2e9d5376500aa
src/tests/master_tests.cpp a044286d10bf1ab0676c7d403a5555f59e0b1fea
src/tests/mesos.hpp e1c06352736c339e8cd336811134054617df1fc6
src/tests/metrics_tests.cpp 9b7f84a8c6b4f56f329577569041621a617aa0cb
src/tests/scheduler_tests.cpp 0f892f9d423f0bc72cdab22452e0ad7965dda444
Diff: https://reviews.apache.org/r/38516/diff/
Testing
-------
Platform: Ubuntu:14.04
make
make check
Thanks,
Guangya Liu
Re: Review Request 38516: Changed quiesceOffers to SuppressOffers
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38516/
-----------------------------------------------------------
(Updated Sept. 19, 2015, 1:27 a.m.)
Review request for mesos and Vinod Kone.
Bugs: MESOS-3037
https://issues.apache.org/jira/browse/MESOS-3037
Repository: mesos
Description
-------
A comment from Vinod: After some discussion with other committers,
most of them felt suppressOffers is better than quiesceOffers.
Diffs (updated)
-----
include/mesos/master/allocator.hpp 2dc631242bca8d5e1d536126770f5bcbab2fefed
include/mesos/scheduler.hpp 071f448153080bfcc967755157cf900994947484
src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp d8acc4fe92fc8dfbd582b165fba24dac492c28d4
src/java/src/org/apache/mesos/MesosSchedulerDriver.java de88463da2f6833633542442a0d66370507c4018
src/java/src/org/apache/mesos/SchedulerDriver.java ba4bc58f57b01ad3705438e1172bf6663e2a2446
src/master/allocator/mesos/allocator.hpp 86f6c5572f831b19a3eb006456320df2a445df45
src/master/allocator/mesos/hierarchical.hpp 8f2232a13b6fa0cd01d0399460f9637858a8c6b8
src/master/master.cpp 64e5fb9e27b2e6797b2ce87c0e1a3ef8a2943e27
src/master/metrics.hpp a3c0c0c18047298179b6d09c4126fe594c0b4eaf
src/master/metrics.cpp 6bce80bace0c2ad01ec0b26de9ecbd401a597988
src/python/interface/src/mesos/interface/__init__.py cd60ead6c6519d7347aec1fd9315735af0fa818a
src/python/native/src/mesos/native/mesos_scheduler_driver_impl.hpp 04e3190949fba8e4675352636b0a649a033f702f
src/python/native/src/mesos/native/mesos_scheduler_driver_impl.cpp 10208b176c9b45d5c9afc096564e27403dcde695
src/sched/sched.cpp 84c2edb2c660f976fd57d1407dd2e9d5376500aa
src/tests/master_tests.cpp a044286d10bf1ab0676c7d403a5555f59e0b1fea
src/tests/mesos.hpp 760dcb7a224141d772098ccd1a7658b2d28f6e21
src/tests/metrics_tests.cpp 9b7f84a8c6b4f56f329577569041621a617aa0cb
src/tests/scheduler_tests.cpp 0f892f9d423f0bc72cdab22452e0ad7965dda444
Diff: https://reviews.apache.org/r/38516/diff/
Testing (updated)
-------
Platform: Ubuntu:14.04
make
make check
Thanks,
Guangya Liu