You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/09/11 09:42:26 UTC
[GitHub] Clarkkkkk commented on a change in pull request #6679:
[FLINK-10223][LOG]Logging with resourceId during taskmanager startup
Clarkkkkk commented on a change in pull request #6679: [FLINK-10223][LOG]Logging with resourceId during taskmanager startup
URL: https://github.com/apache/flink/pull/6679#discussion_r216607446
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerRunner.java
##########
@@ -349,6 +349,8 @@ public static TaskExecutor startTaskManager(
checkNotNull(rpcService);
checkNotNull(highAvailabilityServices);
+ LOG.info("Starting taskManager {}", resourceID);
Review comment:
I think "Starting taskManager with ResourceID: {}, resourceID)" would be more explicit. What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services