You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by TimBarham <gi...@git.apache.org> on 2015/06/10 20:38:14 UTC
[GitHub] cordova-coho pull request: Initial coho handling for the new cordo...
GitHub user TimBarham opened a pull request:
https://github.com/apache/cordova-coho/pull/84
Initial coho handling for the new cordova-serve module in cordova-lib.
1. Adds `cordova-serve` as another "repo" in coho's list of repos (it actually just points to the `cordova-lib` repo, but allows various command to work directly on `cordova-serve`).
2. Adds the ability to work with prefixed tags, so `cordova-serve` can maintain versions independent of `cordova-lib`.
Note that this introduces `cordova-serve` as another "repo" as far as coho is concerned, which I think works ok for now. But ultimately, particularly if we introduce more modules in the `cordova-lib` repo, we should probably add to coho the concept of "modules" or "packages" within repos (so `cordova-serve` would not exist as a separate "repo" in coho's list of repos, but as a module within the `cordova-lib` repo, alongside the `cordova-lib` module) - then, among other benefits, we can provide generic handling for the fact that modules live within sub-directories of their repo (rather than the custom handling we have now).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-coho tb-handle-serve
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-coho/pull/84.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #84
----
commit 6735cdf76b073e6ecaf9154e8730c57e927e6a46
Author: Tim Barham <ti...@microsoft.com>
Date: 2015-06-10T18:22:22Z
Initial handling for the new cordova-serve module in cordova-lib.
1. Adds cordova-serve as another 'repo' (which is really pointing to the cordova-lib repo).
2. Adds the ability to work with prefixed tags, so cordova-serve can maintain versions independent of cordova-lib.
Note that this introduces cordova-serve as another repo as far as COHO is concerned. This works ok for now, but ultimately if we introduce more modules in the cordova-lib repo we should probably add the concept of modules or packages to repos (so cordova-serve would not exist as a 'repo' in COHO, but as a module within the cordova-lib repo) - then. among other benefits, we won't need custom handling for the fact that cordova-lib and cordova-serve live within subdirectories of their repo.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-coho pull request: Initial coho handling for the new cordo...
Posted by TimBarham <gi...@git.apache.org>.
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-coho/pull/84#issuecomment-111765452
Ok, I'm gonna close this an open a new PR with a much more complete change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-coho pull request: Initial coho handling for the new cordo...
Posted by stevengill <gi...@git.apache.org>.
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-coho/pull/84#issuecomment-111257786
Haven't tested this yet, but first question that comes to mind is how would this affect repo-clone?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-coho pull request: Initial coho handling for the new cordo...
Posted by TimBarham <gi...@git.apache.org>.
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-coho/pull/84#issuecomment-111262521
Ah, good question. I'll try it out. I tried a few scenarios, and was trying to think of one where having two items in the repo list pointing to the same repo could cause a problem - that might be a good example. If it causes a problem, I might have to move to the model where we support defining "modules" within a repo (wanted to avoid that for now because it will be a bunch more work).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-coho pull request: Initial coho handling for the new cordo...
Posted by TimBarham <gi...@git.apache.org>.
Github user TimBarham closed the pull request at:
https://github.com/apache/cordova-coho/pull/84
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org