[GitHub] [incubator-doris] imay commented on a change in pull request #2254: Fix bug for showing columns from non exist table doesn't prompt error

[GitBox <gi...@apache.org>]

imay commented on a change in pull request #2254: Fix bug for showing columns from non exist table doesn't prompt error
URL: https://github.com/apache/incubator-doris/pull/2254#discussion_r348303308
 
 

 ##########
 File path: fe/src/main/java/org/apache/doris/qe/ShowExecutor.java
 ##########
 @@ -624,10 +624,14 @@ private void handleShowColumn() throws AnalysisException {
                                                         aggType));
                         }
                     }
+                } else {
+                    throw new AnalysisException("Table " + db.getFullName() + "." + showStmt.getTable() + " no found");
 
 Review comment:
   Better to use ErrorReport and ErrorCode to unify error message and error code. And this code can be written as 
   
   ```
   ErrorReport.reportDdlException(ErrorCode.ERR_BAD_TABLE_ERROR, tableName);
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org