[GitHub] [incubator-datasketches-java] davecromberge commented on a change in pull request #331: Correct minor java doc typos

[GitBox <gi...@apache.org>]

davecromberge commented on a change in pull request #331:
URL: https://github.com/apache/incubator-datasketches-java/pull/331#discussion_r478498938



##########
File path: src/main/java/org/apache/datasketches/BinomialBoundsN.java
##########
@@ -225,9 +225,9 @@ else if (theta < ((numSamplesI) / 360.0)) {  // empirically-determined threshold
    * This must be an integer value of 1, 2 or 3.
    * @param noDataSeen this is normally false. However, in the case where you have zero samples
    * and a theta &lt; 1.0, this flag enables the distinction between a virgin case when no actual
-   * data has been seen and the case where the estimate may be zero but an upper error bound may
+   * data has been seen and the case where the estimate may be zero but a lower error bound may
    * still exist.

Review comment:
       Thanks for clearing that up Lee, it makes sense for a sketch that estimates cardinalities to have those constraints on the error bounds - especially since the numbers refer to cardinalities.
   
   I'm very sorry to hear about the tragic loss of your gifted colleague... I will leave out the reference in that case.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org