You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@jmeter.apache.org by bu...@apache.org on 2012/02/16 10:48:21 UTC
DO NOT REPLY [Bug 52679] New: [Regression] User Paramters columns
narrow
https://issues.apache.org/bugzilla/show_bug.cgi?id=52679
Bug #: 52679
Summary: [Regression] User Paramters columns narrow
Product: JMeter
Version: 2.6
Platform: PC
OS/Version: Windows XP
Status: NEW
Severity: trivial
Priority: P2
Component: Main
AssignedTo: issues@jmeter.apache.org
ReportedBy: immanuel.hayden@gmail.com
Classification: Unclassified
Hi!
Just saw 2.6 release -> nice changes :D
But I also have one issue that I would count as a regression from the 2.5
version: In the User Parameters element the columns are much narrower than they
need to be.
For one user they only fill about half the width of the element. This wouldn't
be an issue if the column would remember the width once you resize it, but
after you switch away from the element and back again the columns are
needlessly narrow again.
So, it would be cool if the columns either stay the width they are resized to
or if they could be as wide as the widest element in them
eg like this:
| Name | User_1 | |
|-------------------------------------| little |
| longvarname | bla | wasted |
| short | even longer var value | space |
currently it's more like this:
| Name | User_1 | |
|-----------------------| much |
| longvarna | bla | wasted |
| short | even long | space |
thanks for considering :)
br,
Imm
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 52679] User Parameters columns narrow
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52679
--- Comment #4 from immanuel.hayden@gmail.com 2012-02-18 15:27:35 UTC ---
while definitely an improvement, as far as I understand this, the table is
still not "content-aware" (eg. mostly short variable names, but much content ->
still two columns with the same width)
I think this guy
http://binkley.blogspot.com/2006/01/getting-jtable-columns-widths-to-fit.html
has the solution that I would describe as best fitting (without the min-width,
but that should be only an if in the right place ;))
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 52679] User Parameters columns narrow
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52679
--- Comment #5 from Philippe Mouawad <p....@ubik-ingenierie.com> 2012-02-28 20:36:13 UTC ---
Hello Milamber,
Until we find a better solution, +1 for your solution.
Regards
Philippe
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 52679] User Parameters columns narrow
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52679
--- Comment #2 from immanuel.hayden@gmail.com 2012-02-18 09:43:11 UTC ---
Created attachment 28350
--> https://issues.apache.org/bugzilla/attachment.cgi?id=28350
min-width vs width
thought so much ;)
this is why my idea was, not so much to change this back (as I quite clearly
see the use of that feature), but to make the column size choice more
intelligent (eg. in css terms: define a min-width instead of a width)
with my bad html and css skills I created the attached mockup. notice how the
second long text gets wrapped when using "width" instead of "min-width" (yes, I
am too stupid to get overflow working just now ;)).
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 52679] [Regression] User Paramters columns narrow
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52679
Philippe Mouawad <p....@ubik-ingenierie.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |p.mouawad@ubik-ingenierie.c
| |om
Platform|PC |All
OS/Version|Windows XP |All
Severity|trivial |regression
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 52679] User Parameters columns narrow
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52679
--- Comment #3 from Milamber <mi...@apache.org> 2012-02-18 13:21:42 UTC ---
Created attachment 28351
--> https://issues.apache.org/bugzilla/attachment.cgi?id=28351
Proposal patch
* Arbitrary minimum size to 200 px after (nb columns * 200) > table width (and
a scroll pane)
* Else column width = table width / nb column (no scroll pane)
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 52679] User Parameters columns narrow
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52679
Philippe Mouawad <p....@ubik-ingenierie.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #7 from Philippe Mouawad <p....@ubik-ingenierie.com> 2012-02-29 13:27:26 UTC ---
Applied, thanks for the patch.
Date: Wed Feb 29 13:25:02 2012
New Revision: 1295094
URL: http://svn.apache.org/viewvc?rev=1295094&view=rev
Log:
Bug 52679 - User Parameters columns narrow
Modified:
jmeter/trunk/src/components/org/apache/jmeter/modifiers/gui/UserParametersGui.java
jmeter/trunk/xdocs/changes.xml
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 52679] User Parameters columns narrow
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52679
--- Comment #6 from immanuel.hayden@gmail.com 2012-02-29 10:06:16 UTC ---
Created attachment 28405
--> https://issues.apache.org/bugzilla/attachment.cgi?id=28405
Proposal Patch II
Sorry this took me so long ... was not trivial for me to get jmeter compiling
because eclipse didn't like it (ended up ditching eclipse in the end).
Anyhow, here is my proposal patch which I patched together from
http://bosmeeuw.wordpress.com/2011/08/07/java-swing-automatically-resize-table-columns-to-their-contents/
... colums are sized to either fit the content (with a little additional
margin) or 100 px minimum width. I am pretty sure there is a more elegant way
to do this, but for now I'm happy it works :D
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 52679] User Parameters columns narrow
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52679
Philippe Mouawad <p....@ubik-ingenierie.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P2 |P5
Summary|[Regression] User Paramters |User Parameters columns
|columns narrow |narrow
--- Comment #1 from Philippe Mouawad <p....@ubik-ingenierie.com> 2012-02-17 20:49:36 UTC ---
This "regression" is an effect of fix to 27112.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.