You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2010/10/06 17:55:31 UTC

[jira] Created: (CASSANDRA-1582) create tests for cli

create tests for cli
--------------------

                 Key: CASSANDRA-1582
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1582
             Project: Cassandra
          Issue Type: New Feature
          Components: Tools
            Reporter: Jonathan Ellis
            Assignee: Pavel Yaskevich
             Fix For: 0.7.1


Would like to have a test for each command so we have a least a little protection against regressions.  No idea how to do this.  Expect? http://en.wikipedia.org/wiki/Expect

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-1582) create tests for cli

Posted by "Pavel Yaskevich (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-1582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12919835#action_12919835 ] 

Pavel Yaskevich commented on CASSANDRA-1582:
--------------------------------------------

Dependents on what should be tested - should we test a grammar (parsing) or evaluation (returning results)? It we want to test a grammar it will be easy...

> create tests for cli
> --------------------
>
>                 Key: CASSANDRA-1582
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1582
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Tools
>            Reporter: Jonathan Ellis
>            Assignee: Pavel Yaskevich
>             Fix For: 0.7.1
>
>
> Would like to have a test for each command so we have a least a little protection against regressions.  No idea how to do this.  Expect? http://en.wikipedia.org/wiki/Expect

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-1582) create tests for cli

Posted by "Pavel Yaskevich (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-1582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12919993#action_12919993 ] 

Pavel Yaskevich commented on CASSANDRA-1582:
--------------------------------------------

What do you think, Jonathan?

> create tests for cli
> --------------------
>
>                 Key: CASSANDRA-1582
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1582
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Tools
>            Reporter: Jonathan Ellis
>            Assignee: Pavel Yaskevich
>             Fix For: 0.7.1
>
>
> Would like to have a test for each command so we have a least a little protection against regressions.  No idea how to do this.  Expect? http://en.wikipedia.org/wiki/Expect

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-1582) create tests for cli

Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-1582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12920220#action_12920220 ] 

Eric Evans commented on CASSANDRA-1582:
---------------------------------------

The system tests would be a good template for how to go about something this I think.  Even better, write the tests in Python and you can take advantage of the existing infrastructure for starting, stopping, and cleaning up after a test instance (see test/system/__init__.py).

> create tests for cli
> --------------------
>
>                 Key: CASSANDRA-1582
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1582
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Tools
>            Reporter: Jonathan Ellis
>            Assignee: Pavel Yaskevich
>             Fix For: 0.7.1
>
>
> Would like to have a test for each command so we have a least a little protection against regressions.  No idea how to do this.  Expect? http://en.wikipedia.org/wiki/Expect

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-1582) create tests for cli

Posted by "Pavel Yaskevich (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-1582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12920013#action_12920013 ] 

Pavel Yaskevich commented on CASSANDRA-1582:
--------------------------------------------

I think that it is helpful because that way we can catch regressions in the grammar with is also a big issue (even bigger that evaluation at some point). As CLI depends on the running cassandra server (for doing evaluation tests) I think I can set up test environment which will start cassandra and run tests but I'm pretty sure it should be done separately from main `ant test`, what do you think if we do `ant cli-test` task which will compile project and run tests for cli, say placed in the src/cli-test directory? I'm not a big Ant expert so it will require some investigation to be done...

> create tests for cli
> --------------------
>
>                 Key: CASSANDRA-1582
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1582
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Tools
>            Reporter: Jonathan Ellis
>            Assignee: Pavel Yaskevich
>             Fix For: 0.7.1
>
>
> Would like to have a test for each command so we have a least a little protection against regressions.  No idea how to do this.  Expect? http://en.wikipedia.org/wiki/Expect

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-1582) create tests for cli

Posted by "Pavel Yaskevich (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pavel Yaskevich updated CASSANDRA-1582:
---------------------------------------

    Attachment: CASSANDRA-1582.patch

> create tests for cli
> --------------------
>
>                 Key: CASSANDRA-1582
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1582
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Tools
>            Reporter: Jonathan Ellis
>            Assignee: Pavel Yaskevich
>             Fix For: 0.7.1
>
>         Attachments: CASSANDRA-1582.patch
>
>
> Would like to have a test for each command so we have a least a little protection against regressions.  No idea how to do this.  Expect? http://en.wikipedia.org/wiki/Expect

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-1582) create tests for cli

Posted by "Pavel Yaskevich (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pavel Yaskevich updated CASSANDRA-1582:
---------------------------------------

    Attachment: CASSANDRA-1582-v2.patch

CLITest is using EmbeddedCassandraService now.

> create tests for cli
> --------------------
>
>                 Key: CASSANDRA-1582
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1582
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Tools
>            Reporter: Jonathan Ellis
>            Assignee: Pavel Yaskevich
>             Fix For: 0.7.1
>
>         Attachments: CASSANDRA-1582-v2.patch, CASSANDRA-1582.patch
>
>
> Would like to have a test for each command so we have a least a little protection against regressions.  No idea how to do this.  Expect? http://en.wikipedia.org/wiki/Expect

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-1582) create tests for cli

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-1582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923001#action_12923001 ] 

Hudson commented on CASSANDRA-1582:
-----------------------------------

Integrated in Cassandra #571 (See [https://hudson.apache.org/hudson/job/Cassandra/571/])
    add cli sanity tests.
patch by Pavel Yaskevich; reviewed by jbellis for CASSANDRA-1582


> create tests for cli
> --------------------
>
>                 Key: CASSANDRA-1582
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1582
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Tools
>            Reporter: Jonathan Ellis
>            Assignee: Pavel Yaskevich
>             Fix For: 0.7.0
>
>         Attachments: CASSANDRA-1582-v2.patch, CASSANDRA-1582.patch
>
>
> Would like to have a test for each command so we have a least a little protection against regressions.  No idea how to do this.  Expect? http://en.wikipedia.org/wiki/Expect

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-1582) create tests for cli

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-1582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12920011#action_12920011 ] 

Jonathan Ellis commented on CASSANDRA-1582:
-------------------------------------------

I had system tests in mind.  Testing the parser alone doesn't seem very useful to catch regressions.  Thoughts?

> create tests for cli
> --------------------
>
>                 Key: CASSANDRA-1582
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1582
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Tools
>            Reporter: Jonathan Ellis
>            Assignee: Pavel Yaskevich
>             Fix For: 0.7.1
>
>
> Would like to have a test for each command so we have a least a little protection against regressions.  No idea how to do this.  Expect? http://en.wikipedia.org/wiki/Expect

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.