You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "xxsc0529 (via GitHub)" <gi...@apache.org> on 2024/07/23 02:25:19 UTC

[PR] [Feature][Dashboard] Dashboard Add Oceanbase Support [inlong]

xxsc0529 opened a new pull request, #10698:
URL: https://github.com/apache/inlong/pull/10698

   <!-- Prepare a Pull Request
   Change the title of pull request refer to the following example:
     [INLONG-XYZ][Component] Title of the pull request 
   -->
   
   <!-- Specify the issue this pull request going to fix.
   The following *XYZ* should be replaced by the actual [GitHub Issue](https://github.com/apache/inlong/issues) number)-->
   
   Fixes #10632
   
   ### Motivation
   Added support for Oceanbase data sources to adapt to the Oceanbase ecosystem. close #10632
   <!--Explain here the context, and why you're making that change. What is the problem you're trying to solve.-->
   
   ### Modifications
   It mainly adds oceanbase data source support and uses the oceanbase-client driver to connect.
   <!--Describe the modifications you've done.-->
   It mainly adds oceanbase data source support and uses the oceanbase-client driver to connect. And write oceanbase's ExtractNode logic and LoadNode logic. The specific implementation logic is the same as mysql.Added support for oceanbase on the front-end page. Since the jdbc-inlong processing logic in the flink15 connection lacks the jdbc dialect, an error is reported. This is modified here.
   ### Verifying this change
   
   *(Please pick either of the following options)*
   
   - [ ] This change is a trivial rework/code cleanup without any test coverage.
   
   - [ ] This change is already covered by existing tests, such as:
     *(please describe tests)*
   Here's how the page test works
   ![image](https://github.com/user-attachments/assets/5fc8d69b-4536-4f55-9eb7-4bce1cdeb089)
   ![image](https://github.com/user-attachments/assets/23a29bd4-c33e-408c-9cfa-4bf778b1a9c3)
   ![image](https://github.com/user-attachments/assets/7fcb9917-6054-4783-9aa7-06305887d853)
   ![image](https://github.com/user-attachments/assets/89468952-232a-4cc8-a1a9-aee0df308c86)
   
   - [ ] This change added tests and can be verified as follows:
   Please use the following test classes for testing  org.apache.inlong.sort.parser.MySqlExtractNodeToOceanBaseLoadNodeTest
     *(example:)*
     - *Added integration tests for end-to-end deployment with large payloads (10MB)*
     - *Extended integration test for recovery after broker failure*
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (yes / no) yes
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)  Data source types have been added to the README.md
     - If a feature is not applicable for documentation, explain why?
     - If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [INLONG-10632][Dashboard] Dashboard Add Oceanbase Support [inlong]

Posted by "aloyszhang (via GitHub)" <gi...@apache.org>.
aloyszhang commented on PR #10698:
URL: https://github.com/apache/inlong/pull/10698#issuecomment-2244185187

   Thanks for your contribution.
   Just one thing, you should create a brand new issue for this pull request, so do the pull requests #10700 and #10701.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [INLONG-10632][Dashboard] Dashboard Add Oceanbase Support [inlong]

Posted by "dockerzhang (via GitHub)" <gi...@apache.org>.
dockerzhang merged PR #10698:
URL: https://github.com/apache/inlong/pull/10698


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [INLONG-10632][Dashboard] Dashboard Add Oceanbase Support [inlong]

Posted by "xxsc0529 (via GitHub)" <gi...@apache.org>.
xxsc0529 commented on PR #10698:
URL: https://github.com/apache/inlong/pull/10698#issuecomment-2244301887

   > Thanks for your contribution. You should create a new issue for this pull request, and so do the pull requests #10700 and #10701. Also, the pull request's title and commit message must be modified to keep the new issue consistent.
   
   Modifications have been made


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org