[GitHub] [flink-kubernetes-operator] bgeng777 commented on a change in pull request #120: [FLINK-26881] Pick up the savepoint directory in the flink config when trigger savepoint

[GitBox <gi...@apache.org>]

bgeng777 commented on a change in pull request #120:
URL: https://github.com/apache/flink-kubernetes-operator/pull/120#discussion_r836262239



##########
File path: flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/FlinkService.java
##########
@@ -172,10 +174,14 @@ public boolean isJobManagerPortReady(Configuration config) {
                     clusterClient.cancel(jobID).get(1, TimeUnit.MINUTES);
                     break;
                 case SAVEPOINT:
+                    final String savepointDirectory =
+                            Preconditions.checkNotNull(
+                                    conf.get(CheckpointingOptions.SAVEPOINT_DIRECTORY));
+                    final long timeout = operatorConfiguration.getFlinkClientTimeout().getSeconds();

Review comment:
       Is the [execution.checkpointing.timeout](https://nightlies.apache.org/flink/flink-docs-master/zh/docs/deployment/config/#execution-checkpointing-timeout) what we want?
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org