[GitHub] [spark] wangyum commented on a change in pull request #24592: [SPARK-27690][SQL] Remove materialized views first in `HiveClientImpl.reset`

[GitBox <gi...@apache.org>]

wangyum commented on a change in pull request #24592: [SPARK-27690][SQL] Remove materialized views first in `HiveClientImpl.reset`
URL: https://github.com/apache/spark/pull/24592#discussion_r284491424
 
 

 ##########
 File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
 ##########
 @@ -856,9 +856,20 @@ private[hive] class HiveClientImpl(
   }
 
   def reset(): Unit = withHiveState {
-    client.getAllTables("default").asScala.foreach { t =>
+    val allTables = client.getAllTables("default")
+    val (mvs, others) = allTables.asScala.map(t => client.getTable("default", t))
+      .partition(_.getTableType.toString.equals("MATERIALIZED_VIEW"))
+
+    // Remove materialized view first, otherwise caused a violation of foreign key constraint.
 
 Review comment:
   Test in another PR: https://github.com/apache/spark/pull/23992

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org