You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/06/13 06:29:29 UTC
[GitHub] [hadoop-ozone] adoroszlai opened a new pull request #1071: HDDS-3795. No coverage reported for Ozone FS
adoroszlai opened a new pull request #1071:
URL: https://github.com/apache/hadoop-ozone/pull/1071
## What changes were proposed in this pull request?
Ozone FS has some tests, but [0% coverage](https://codecov.io/gh/apache/hadoop-ozone/tree/96f07d5c27ba8f2ab9d77df25e10d4cb94489e5f/hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone). This change fixes the problem.
https://issues.apache.org/jira/browse/HDDS-3795
## How was this patch tested?
Ran `TestOzoneFSInputStream`, verified that non-zero coverage is reported for `OzoneFSInputStream` (`coverage.sh` is taken from HDDS-3796):
```
mvn -Dskip.npx -Dskip.installnpx -DskipShade clean package
hadoop-ozone/dev-support/checks/unit.sh -DfailIfNoTests=false -Dtest=TestOzoneFSInputStream
hadoop-ozone/dev-support/checks/coverage.sh
open target/coverage/all/org.apache.hadoop.fs.ozone/OzoneFSInputStream.html
```
Now the package has [70% coverage](https://codecov.io/gh/adoroszlai/hadoop-ozone/tree/HDDS-3795/hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone).
https://github.com/adoroszlai/hadoop-ozone/runs/767653969
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] bharatviswa504 commented on pull request #1071: HDDS-3795. No coverage reported for Ozone FS
Posted by GitBox <gi...@apache.org>.
bharatviswa504 commented on pull request #1071:
URL: https://github.com/apache/hadoop-ozone/pull/1071#issuecomment-643731701
Thank You @adoroszlai for the contribution and @vivekratnavel for the review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on pull request #1071: HDDS-3795. No coverage reported for Ozone FS
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #1071:
URL: https://github.com/apache/hadoop-ozone/pull/1071#issuecomment-643731950
Thanks @vivekratnavel for the review, and @bharatviswa504 for reviewing and committing it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] vivekratnavel commented on pull request #1071: HDDS-3795. No coverage reported for Ozone FS
Posted by GitBox <gi...@apache.org>.
vivekratnavel commented on pull request #1071:
URL: https://github.com/apache/hadoop-ozone/pull/1071#issuecomment-643710959
@adoroszlai Thanks for catching this and working on the fix! +1 LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] bharatviswa504 merged pull request #1071: HDDS-3795. No coverage reported for Ozone FS
Posted by GitBox <gi...@apache.org>.
bharatviswa504 merged pull request #1071:
URL: https://github.com/apache/hadoop-ozone/pull/1071
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] codecov-commenter commented on pull request #1071: HDDS-3795. No coverage reported for Ozone FS
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1071:
URL: https://github.com/apache/hadoop-ozone/pull/1071#issuecomment-643601860
# [Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1071?src=pr&el=h1) Report
> Merging [#1071](https://codecov.io/gh/apache/hadoop-ozone/pull/1071?src=pr&el=desc) into [master](https://codecov.io/gh/apache/hadoop-ozone/commit/bd88eec9fec06a8f8adcbe4d257c5ccaca144f4c&el=desc) will **increase** coverage by `0.98%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/hadoop-ozone/pull/1071?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1071 +/- ##
============================================
+ Coverage 69.36% 70.35% +0.98%
- Complexity 9097 9225 +128
============================================
Files 961 961
Lines 48127 48127
Branches 4676 4676
============================================
+ Hits 33383 33858 +475
+ Misses 12524 12009 -515
- Partials 2220 2260 +40
```
| [Impacted Files](https://codecov.io/gh/apache/hadoop-ozone/pull/1071?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apache/hadoop/hdds/scm/node/StaleNodeHandler.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1071/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvc2VydmVyLXNjbS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL2hkZHMvc2NtL25vZGUvU3RhbGVOb2RlSGFuZGxlci5qYXZh) | `88.88% <0.00%> (-11.12%)` | `4.00% <0.00%> (ø%)` | |
| [...hdds/scm/container/common/helpers/ExcludeList.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1071/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3AvaGRkcy9zY20vY29udGFpbmVyL2NvbW1vbi9oZWxwZXJzL0V4Y2x1ZGVMaXN0LmphdmE=) | `75.51% <0.00%> (-10.21%)` | `18.00% <0.00%> (-3.00%)` | |
| [...g/apache/hadoop/hdds/utils/ResourceLimitCache.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1071/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3AvaGRkcy91dGlscy9SZXNvdXJjZUxpbWl0Q2FjaGUuamF2YQ==) | `84.37% <0.00%> (-9.38%)` | `7.00% <0.00%> (-1.00%)` | |
| [...apache/hadoop/hdds/scm/block/BlockManagerImpl.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1071/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvc2VydmVyLXNjbS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL2hkZHMvc2NtL2Jsb2NrL0Jsb2NrTWFuYWdlckltcGwuamF2YQ==) | `66.66% <0.00%> (-5.41%)` | `18.00% <0.00%> (ø%)` | |
| [...apache/hadoop/ozone/client/io/KeyOutputStream.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1071/diff?src=pr&el=tree#diff-aGFkb29wLW96b25lL2NsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL296b25lL2NsaWVudC9pby9LZXlPdXRwdXRTdHJlYW0uamF2YQ==) | `78.75% <0.00%> (-1.67%)` | `45.00% <0.00%> (-2.00%)` | |
| [...he/hadoop/ozone/om/ha/OMFailoverProxyProvider.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1071/diff?src=pr&el=tree#diff-aGFkb29wLW96b25lL2NvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL296b25lL29tL2hhL09NRmFpbG92ZXJQcm94eVByb3ZpZGVyLmphdmE=) | `82.03% <0.00%> (-0.79%)` | `33.00% <0.00%> (-1.00%)` | |
| [...iner/common/statemachine/DatanodeStateMachine.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1071/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvY29udGFpbmVyLXNlcnZpY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9jb250YWluZXIvY29tbW9uL3N0YXRlbWFjaGluZS9EYXRhbm9kZVN0YXRlTWFjaGluZS5qYXZh) | `82.87% <0.00%> (-0.56%)` | `29.00% <0.00%> (-1.00%)` | |
| [.../transport/server/ratis/ContainerStateMachine.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1071/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvY29udGFpbmVyLXNlcnZpY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9jb250YWluZXIvY29tbW9uL3RyYW5zcG9ydC9zZXJ2ZXIvcmF0aXMvQ29udGFpbmVyU3RhdGVNYWNoaW5lLmphdmE=) | `69.36% <0.00%> (+0.22%)` | `59.00% <0.00%> (+1.00%)` | |
| [.../apache/hadoop/ozone/om/OmMetadataManagerImpl.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1071/diff?src=pr&el=tree#diff-aGFkb29wLW96b25lL296b25lLW1hbmFnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9vbS9PbU1ldGFkYXRhTWFuYWdlckltcGwuamF2YQ==) | `82.52% <0.00%> (+0.26%)` | `92.00% <0.00%> (+1.00%)` | |
| [.../ozone/container/common/volume/AbstractFuture.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1071/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvY29udGFpbmVyLXNlcnZpY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9jb250YWluZXIvY29tbW9uL3ZvbHVtZS9BYnN0cmFjdEZ1dHVyZS5qYXZh) | `30.38% <0.00%> (+0.51%)` | `20.00% <0.00%> (+1.00%)` | |
| ... and [14 more](https://codecov.io/gh/apache/hadoop-ozone/pull/1071/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1071?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1071?src=pr&el=footer). Last update [bd88eec...73371ce](https://codecov.io/gh/apache/hadoop-ozone/pull/1071?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org