[jira] [Commented] (MINIFI-128) NPE if nifi.minifi.notifier.file.config.path wasn't configured

["Aldrin Piri (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MINIFI-128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15765164#comment-15765164 ] 

Aldrin Piri commented on MINIFI-128:
------------------------------------

This is appropriately caught before an NPE with some of the changes done to Ingestors.  Can cleanup stack trace and adjust wording a bit.

> NPE if nifi.minifi.notifier.file.config.path wasn't configured
> --------------------------------------------------------------
>
>                 Key: MINIFI-128
>                 URL: https://issues.apache.org/jira/browse/MINIFI-128
>             Project: Apache NiFi MiNiFi
>          Issue Type: Bug
>          Components: Agent Configuration/Installation
>    Affects Versions: 0.0.1
>         Environment: current master branch build
>            Reporter: Andrew Grande
>            Assignee: Aldrin Piri
>            Priority: Minor
>
> When enabling a FileChangeNotifier, it's easy to forget uncommenting the *nifi.minifi.notifier.file.config.path* property (required). Minifi restart will throw an unfriendly error:
> {noformat}
> Exception in thread "main" java.lang.IllegalArgumentException: Property, nifi.minifi.notifier.file.config.path, for the path of the config file must be specified.
>         at org.apache.nifi.minifi.bootstrap.configuration.notifiers.FileChangeNotifier.initialize(FileChangeNotifier.java:154)
>         at org.apache.nifi.minifi.bootstrap.RunMiNiFi.initializeNotifiers(RunMiNiFi.java:1452)
>         at org.apache.nifi.minifi.bootstrap.RunMiNiFi.start(RunMiNiFi.java:1116)
>         at org.apache.nifi.minifi.bootstrap.RunMiNiFi.main(RunMiNiFi.java:224)
> Initiating shutdown of bootstrap change notifiers...
> Exception in thread "Thread-2" java.lang.NullPointerException
>         at java.util.Collections$UnmodifiableCollection.<init>(Collections.java:1026)
>         at java.util.Collections$UnmodifiableSet.<init>(Collections.java:1128)
>         at java.util.Collections.unmodifiableSet(Collections.java:1118)
>         at org.apache.nifi.minifi.bootstrap.RunMiNiFi.getChangeNotifiers(RunMiNiFi.java:1438)
>         at org.apache.nifi.minifi.bootstrap.ShutdownHook.run(ShutdownHook.java:57)
> {noformat}
> Expected: improve the error message to be meaningful and suggest the user configure the property. No stacktrace, as we know what's going on exactly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)