You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/12/17 22:08:38 UTC

[GitHub] [tvm] altanh commented on a change in pull request #7083: [RELAY,TOPI] Threefry PRNG: splittable and stateless

altanh commented on a change in pull request #7083:
URL: https://github.com/apache/tvm/pull/7083#discussion_r545434990



##########
File path: src/relay/op/random/kernel.cc
##########
@@ -25,21 +25,23 @@ namespace relay {
 
 TVM_REGISTER_NODE_TYPE(ThreefryGenerateAttrs);
 
+static const TensorType THREEFRY_KEY_TYPE = TensorType({10}, tvm::DataType::UInt(64));

Review comment:
       Got it, is the naming style OK for a static function? `THREEFRY_KEY_TYPE()`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org