You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2016/02/19 01:26:47 UTC

Review Request 43746: Fixed flaky AvailableResourcesAfterRescinding test.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43746/
-----------------------------------------------------------

Review request for mesos and Michael Park.


Repository: mesos


Description
-------

Ensure the test does not finish before offer rescinds have been
processed by the scheduler.


Diffs
-----

  src/tests/master_quota_tests.cpp 8357ec911b2a158632a708ae3adff6eabc536697 

Diff: https://reviews.apache.org/r/43746/diff/


Testing
-------

On Mac OS 10.10.4:
`GTEST_FILTER="*AvailableResourcesAfterRescinding*" ./bin/mesos-tests.sh --gtest_repeat=1000 --gtest_break_on_failure`


Thanks,

Alexander Rukletsov


Re: Review Request 43746: Fixed flaky AvailableResourcesAfterRescinding test.

Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43746/#review119782
-----------------------------------------------------------


Ship it!




Ship It!

- Guangya Liu


On 二月 19, 2016, 12:26 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43746/
> -----------------------------------------------------------
> 
> (Updated 二月 19, 2016, 12:26 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Ensure the test does not finish before offer rescinds have been
> processed by the scheduler.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_quota_tests.cpp 8357ec911b2a158632a708ae3adff6eabc536697 
> 
> Diff: https://reviews.apache.org/r/43746/diff/
> 
> 
> Testing
> -------
> 
> On Mac OS 10.10.4:
> `GTEST_FILTER="*AvailableResourcesAfterRescinding*" ./bin/mesos-tests.sh --gtest_repeat=1000 --gtest_break_on_failure`
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Re: Review Request 43746: Fixed flaky AvailableResourcesAfterRescinding test.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43746/#review119836
-----------------------------------------------------------



Patch looks great!

Reviews applied: [43746]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 19, 2016, 12:26 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43746/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2016, 12:26 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Ensure the test does not finish before offer rescinds have been
> processed by the scheduler.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_quota_tests.cpp 8357ec911b2a158632a708ae3adff6eabc536697 
> 
> Diff: https://reviews.apache.org/r/43746/diff/
> 
> 
> Testing
> -------
> 
> On Mac OS 10.10.4:
> `GTEST_FILTER="*AvailableResourcesAfterRescinding*" ./bin/mesos-tests.sh --gtest_repeat=1000 --gtest_break_on_failure`
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>