You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "Tim Robertson (JIRA)" <ji...@apache.org> on 2018/05/18 06:00:00 UTC
[jira] [Assigned] (BEAM-4342) Enforce ErrorProne analysis in the
hadoop IO projects
[ https://issues.apache.org/jira/browse/BEAM-4342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim Robertson reassigned BEAM-4342:
-----------------------------------
Assignee: Tim Robertson
> Enforce ErrorProne analysis in the hadoop IO projects
> -----------------------------------------------------
>
> Key: BEAM-4342
> URL: https://issues.apache.org/jira/browse/BEAM-4342
> Project: Beam
> Issue Type: Improvement
> Components: io-java-hadoop
> Reporter: Scott Wegner
> Assignee: Tim Robertson
> Priority: Minor
> Labels: errorprone, starter
>
> Java ErrorProne static analysis was [recently enabled|https://github.com/apache/beam/pull/5161] in the Gradle build process, but only as warnings. ErrorProne errors are generally useful and easy to fix. Some work was done to [make sdks-java-core ErrorProne-clean|https://github.com/apache/beam/pull/5319] and add enforcement. This task is clean ErrorProne warnings and add enforcement in {{beam-sdks-java-io-hadoop-*}}. Additional context discussed on the [dev list|https://lists.apache.org/thread.html/95aae2785c3cd728c2d3378cbdff2a7ba19caffcd4faa2049d2e2f46@%3Cdev.beam.apache.org%3E].
> Fixing this issue will involve:
> # Follow instructions in the [Contribution Guide|https://beam.apache.org/contribute/] to set up a {{beam}} development environment.
> # Run the following command to compile and run ErrorProne analysis on the project: {{./gradlew :beam-sdks-java-io-hadoop-common:assemble :beam-sdks-java-io-hadoop-file-system:assemble :beam-sdks-java-io-hadoop-input-format:assemble}}
> # Fix each ErrorProne warning from the {{sdks/java/io/hadoop*}} projects.
> # In {{sdks/java/io/hadoop-common/build.gradle}}, {{sdks/java/io/hadoop-file-system/build.gradle}}, and {{sdks/java/io/hadoop-input-format/build.gradle}}, add {{failOnWarning: true}} to the call the {{applyJavaNature()}} ([example|https://github.com/apache/beam/pull/5319/files#diff-9390c20635aed5f42f83b97506a87333R20]).
> This starter issue is sponsored by [~swegner]. Feel free to [reach out|https://beam.apache.org/community/contact-us/] with questions or code review:
> * JIRA: [~swegner]
> * GitHub: [@swegner|https://github.com/swegner]
> * Slack: [@Scott Wegner|https://s.apache.org/beam-slack-channel]
> * Email: swegner at google dot com
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)