You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/07/23 18:55:00 UTC
[jira] [Commented] (DISPATCH-1749) [Test] system_test router
function wait_ready does not wait long enough
[ https://issues.apache.org/jira/browse/DISPATCH-1749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17386478#comment-17386478 ]
ASF GitHub Bot commented on DISPATCH-1749:
------------------------------------------
ChugR commented on pull request #827:
URL: https://github.com/apache/qpid-dispatch/pull/827#issuecomment-885835936
Thanks for the comments @jiridanek but I'm withdrawing this PR. The new code presented here is itself open to problems as yet unseen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> [Test] system_test router function wait_ready does not wait long enough
> -----------------------------------------------------------------------
>
> Key: DISPATCH-1749
> URL: https://issues.apache.org/jira/browse/DISPATCH-1749
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Tests
> Affects Versions: 1.12.0
> Reporter: Charles E. Rolke
> Assignee: Charles E. Rolke
> Priority: Major
>
> On RHEL/Centos 7 systems sometimes system_tests_policy.VhostPolicyConfigHashPattern sometimes fails with the same pattern as DISPATCH-1689. The VhostPolicyConfigHashPattern test is simply trying to verify that the router processes the config file without exiting due to a config error.
> In DISPATCH-1689 the test framework is trying to tear down the router before the router is up. Then the test report shows something like:
> {code:java}
> RuntimeError: Errors during teardown:
> Process 5978 error: exit code -15, expected 0
> {code}
> Normally the policy test passes. When it fails, though, it prints the tail of the router log file. The log snippet shows that the router is shut down before it prints the server log line
> {code:java}
> SERVER (info) Running in DEBUG Mode
> {code}
> Most likely the policy test problem is that the router.wait_ready function opens the listener socket, closes the socket, and returns success so quickly that the router never gets to log the socket open/close and print the rest of the router boot log messages. Once this happens then the test framework falls into the DISPATCH-1689 trap and declares a false failure.
> There are several options for making wait_ready wait until the router is really up.
> * Grep the log for the "SERVER (info) Running" message
> * Require a successful _qdstat -g_ on routers.addresses[0]
> * ???
> Each of these options has drawbacks.
> There are any number of problems in the test suite that could be directly related to wait_ready not waiting long enough.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org