[GitHub] storm pull request #1656: STORM-2057 Support JOIN statement in Storm SQL

[HeartSaVioR <gi...@git.apache.org>]

Github user HeartSaVioR commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1656#discussion_r76744260
  
    --- Diff: storm-core/src/jvm/org/apache/storm/trident/operation/impl/JoinerMultiReducer.java ---
    @@ -139,21 +138,5 @@ private boolean increment(List[] lengths, int[] indices, int j, int overrideInde
             }
             return true;
         }
    -    
    -    public static class JoinState {
    -        List<List>[] sides;
    -        int numSidesReceived = 0;
    -        int[] indices;
    -        TridentTuple group;
    -        
    -        public JoinState(int numSides, TridentTuple group) {
    -            sides = new List[numSides];
    -            indices = new int[numSides];
    -            this.group = group;
    -            for(int i=0; i<numSides; i++) {
    -                sides[i] = new ArrayList<List>();
    -            }            
    -        }
    -    }
    -    
    +
    --- End diff --
    
    Moved JoinState to its own Java file since two classes refer JoinState now.
    It's a kind of public class, but only JoinerMultiReducer uses this and it resides on `impl` directory so I think it's OK to move.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---