You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "liuxiaocs7 (via GitHub)" <gi...@apache.org> on 2026/08/25 17:31:35 UTC

[PR] fix(settings): fix Tavily key label cursor and reunite the apply link [maka]

liuxiaocs7 opened a new pull request, #3821:
URL: https://github.com/apache/maka/pull/3821

   ## Summary
   
   Two small UI papercuts in **Settings → Web search**'s Tavily key field:
   
   - **Misleading cursor.** The key label ("Tavily 密钥" / "Tavily key") showed a hand (pointer) cursor on hover but forwards no click. Astryx `FieldLabel` renders an `InputGroup` label as a bare `<span class="astryx-field-label">` (`isGroupLabel`), which carries StyleX `cursor: pointer`; `native-cursor.css` (the single owner of the "hand cursor is for links only" convention) only neutralized real `<label>` elements, so the span slipped through. Match the stable `themeProps` class (`.astryx-field-label`) so group-label spans get `cursor: default` like every other field label. This is app-wide by design — the same shared `PasswordInput` backs bot tokens, provider API keys, and the proxy password.
   - **Apply URL split from its label.** "申请地址:" / "Apply at:" rendered above the input as the field description, while the `tavily.com` link rendered on its own line below the input, so the key input split the label from its URL. Fold the link into the description as a `ReactNode` so "申请地址:tavily.com" reads as one unit above the input — a pattern Astryx `FieldLabel` supports (its click forwarding skips nested interactive content); only `InputGroup`/`Field` under-declare the `description` prop as `string`, papered over by one cast in `PasswordInput`.
   
   Fixes #3820
   
   ## Verification
   
   - `tsc -p tsconfig.renderer.json --noEmit` — passes
   - `biome lint` on the changed files — passes
   
   Before / after (Tavily key field):
   
   ```
   Before                               After
   ─────────────────────────────       ─────────────────────────────
   Tavily 密钥        (hand cursor)     Tavily 密钥        (arrow cursor)
   密钥只保存在本机。申请地址:           密钥只保存在本机。申请地址:tavily.com
   ┌───────────────────────────┐        ┌───────────────────────────┐
   │ tvly-xxxxxxxx      👁 📋 │          │ tvly-xxxxxxxx      👁 📋 │
   └───────────────────────────┘        └───────────────────────────┘
   tavily.com   ← split below input
   ```
   
   ## Review focus
   
   The cursor fix in `native-cursor.css` is intentionally app-wide: it neutralizes the hand cursor on every `InputGroup` group-label span, not just this page.
   
   ## AI use
   
   Select exactly one:
   
   - [ ] No generative tool made a substantive contribution
   - [x] Generative tooling made a substantive contribution
   
   Tool(s) and scope: Claude Code (Opus 4.8) — investigated the root cause, wrote the code changes, and drafted this PR. Reviewed by the author. The squash commit carries a `Generated-by` trailer.
   
   ## Checklist
   
   - [ ] Tests cover the change and fail without it
   - [x] Lint, format, typecheck and the affected suites pass locally
   
   Does this PR entail a change in behavior?
   
   - [x] Yes — described under Summary above
   - [ ] No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org


Re: [PR] fix(settings): fix Tavily key label cursor and reunite the apply link [maka]

Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han merged PR #3821:
URL: https://github.com/apache/maka/pull/3821


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org