[GitHub] gaborgsomogyi edited a comment on issue #23732: [SPARK-26389][SS] Add force delete temp checkpoint configuration

[GitBox <gi...@apache.org>]

gaborgsomogyi edited a comment on issue #23732: [SPARK-26389][SS] Add force delete temp checkpoint configuration
URL: https://github.com/apache/spark/pull/23732#issuecomment-461142314
 
 
   > The flag description is a bit confusing; I would just describe the behavior when the flag is on, rather than saying it’s “normal” deletion.
   
   Clear, will do.
   
   > I think the new flag should be read in DataStreamWriter, so the shouldDelete value we pass into StreamExecution will always be correct.
   
   `shouldDelete` flag is actually `shouldDeleteIfQueryNotFailed` and `DataStreamWriter` doesn't know whether the query stopped without exception. Do you mean change actual behaviour?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org