[GitHub] [arrow] nealrichardson commented on a change in pull request #11730: ARROW-14745: [R] Enable true duckdb streaming

[GitBox <gi...@apache.org>]

nealrichardson commented on a change in pull request #11730:
URL: https://github.com/apache/arrow/pull/11730#discussion_r793029269



##########
File path: r/R/duckdb.R
##########
@@ -155,6 +154,5 @@ to_arrow <- function(.data) {
   # Run the query
   res <- DBI::dbSendQuery(dbplyr::remote_con(.data), dbplyr::remote_query(.data), arrow = TRUE)
 
-  # TODO: we shouldn't need $read_table(), but we get segfaults when we do.
-  arrow_dplyr_query(duckdb::duckdb_fetch_record_batch(res)$read_table())
+  duckdb::duckdb_fetch_record_batch(res)

Review comment:
       If you keep the `arrow_dplyr_query()` around this here then you don't need to add all of the RecordBatchReader methods




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org