[GitHub] xrmx commented on a change in pull request #3461: Fixed dashboard filters carrying over to explore slice

[gi...@git.apache.org]

xrmx commented on a change in pull request #3461: Fixed dashboard filters carrying over to explore slice
URL: https://github.com/apache/incubator-superset/pull/3461#discussion_r138822610
 
 

 ##########
 File path: superset/assets/javascripts/modules/superset.js
 ##########
 @@ -207,11 +203,16 @@ const px = function (state) {
         } else {
           this.force = force;
         }
+        const formDataExtra = Object.assign({}, formData);
+        const extraFilters = controller.effectiveExtraFilters(sliceId);
+        formDataExtra.filters = formDataExtra.filters.concat(extraFilters);
+        controls.find('a.exploreChart').attr('href', getExploreUrl(formDataExtra));
 
 Review comment:
   Does not look a very react-ish way to handle this, shouldn't the component that renders the link should take formDataExtra and render again when it changes?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services