You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/05/22 12:36:41 UTC
[GitHub] [commons-compress] arturobernalg opened a new pull request #196: COMPRESS-580 - Remove redundant operation
arturobernalg opened a new pull request #196:
URL: https://github.com/apache/commons-compress/pull/196
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-compress] bodewig commented on a change in pull request #196: COMPRESS-580 - Remove redundant operation
Posted by GitBox <gi...@apache.org>.
bodewig commented on a change in pull request #196:
URL: https://github.com/apache/commons-compress/pull/196#discussion_r637403654
##########
File path: src/main/java/org/apache/commons/compress/archivers/arj/ArjArchiveInputStream.java
##########
@@ -115,10 +115,10 @@ private String readString(final DataInputStream dataIn) throws IOException {
buffer.write(nextByte);
}
if (charsetName != null) {
- return new String(buffer.toByteArray(), charsetName);
+ return buffer.toString(charsetName);
Review comment:
oh, I was unaware of ByteArrayOutputStream#toString(String). Learn something new every day. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-compress] coveralls commented on pull request #196: COMPRESS-580 - Remove redundant operation
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #196:
URL: https://github.com/apache/commons-compress/pull/196#issuecomment-846402880
[](https://coveralls.io/builds/39917494)
Coverage remained the same at 86.819% when pulling **ce1c3f0d6d3ef873d43fa1337821800de7cc77ce on arturobernalg:feature/COMPRESS-580** into **9bc02b24a67db2783ca6817278e4b6b218677e26 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-compress] bodewig merged pull request #196: COMPRESS-580 - Remove redundant operation
Posted by GitBox <gi...@apache.org>.
bodewig merged pull request #196:
URL: https://github.com/apache/commons-compress/pull/196
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org