You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Girish Shilamkar <gi...@clogeny.com> on 2013/07/24 12:51:25 UTC

Review Request 12897: CLOUDSTACK-3594: Fix regression in Affinity Groups tests

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12897/
-----------------------------------------------------------

Review request for cloudstack and Prasanna Santhanam.


Bugs: CLOUDSTACK-3594


Repository: cloudstack-git


Description
-------

One of the patches introduced a regression where account
and domainid parameters were changed. Therefore Affinity
Groups for those accounts were not found and tests failed.


Diffs
-----

  tools/marvin/marvin/integration/lib/base.py 6e49ae5 

Diff: https://reviews.apache.org/r/12897/diff/


Testing
-------


Thanks,

Girish Shilamkar

Re: Review Request 12897: CLOUDSTACK-3594: Fix regression in Affinity Groups tests

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12897/#review23751
-----------------------------------------------------------


Commit 4a7f5d59d6f77fdeb5623937f4efa2542f891573 in branch refs/heads/4.2 from Girish Shilamkar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=4a7f5d5 ]

CLOUDSTACK-3594: Fix regression in Affinity Groups tests

One of the patches introduced a regression where account
and domainid parameters were changed. Therefore Affinity
Groups for those accounts were not found and tests failed.

Signed-off-by: Prasanna Santhanam <ts...@apache.org>


- ASF Subversion and Git Services


On July 24, 2013, 10:51 a.m., Girish Shilamkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12897/
> -----------------------------------------------------------
> 
> (Updated July 24, 2013, 10:51 a.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Bugs: CLOUDSTACK-3594
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> One of the patches introduced a regression where account
> and domainid parameters were changed. Therefore Affinity
> Groups for those accounts were not found and tests failed.
> 
> 
> Diffs
> -----
> 
>   tools/marvin/marvin/integration/lib/base.py 6e49ae5 
> 
> Diff: https://reviews.apache.org/r/12897/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Girish Shilamkar
> 
>

Re: Review Request 12897: CLOUDSTACK-3594: Fix regression in Affinity Groups tests

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12897/#review23748
-----------------------------------------------------------


Commit b8a38ca7bd866db32dba644f8fc1be5d3406e16c in branch refs/heads/master from Girish Shilamkar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=b8a38ca ]

CLOUDSTACK-3594: Fix regression in Affinity Groups tests

One of the patches introduced a regression where account
and domainid parameters were changed. Therefore Affinity
Groups for those accounts were not found and tests failed.

Signed-off-by: Prasanna Santhanam <ts...@apache.org>
(cherry picked from commit 4a7f5d59d6f77fdeb5623937f4efa2542f891573)


- ASF Subversion and Git Services


On July 24, 2013, 10:51 a.m., Girish Shilamkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12897/
> -----------------------------------------------------------
> 
> (Updated July 24, 2013, 10:51 a.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Bugs: CLOUDSTACK-3594
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> One of the patches introduced a regression where account
> and domainid parameters were changed. Therefore Affinity
> Groups for those accounts were not found and tests failed.
> 
> 
> Diffs
> -----
> 
>   tools/marvin/marvin/integration/lib/base.py 6e49ae5 
> 
> Diff: https://reviews.apache.org/r/12897/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Girish Shilamkar
> 
>

Re: Review Request 12897: CLOUDSTACK-3594: Fix regression in Affinity Groups tests

Posted by "Jenkins Cloudstack.org" <hu...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12897/#review23754
-----------------------------------------------------------


Review 12897 PASSED the build test
The url of build cloudstack-master-with-patch #30 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/30/

- Jenkins Cloudstack.org


On July 24, 2013, 10:51 a.m., Girish Shilamkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12897/
> -----------------------------------------------------------
> 
> (Updated July 24, 2013, 10:51 a.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Bugs: CLOUDSTACK-3594
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> One of the patches introduced a regression where account
> and domainid parameters were changed. Therefore Affinity
> Groups for those accounts were not found and tests failed.
> 
> 
> Diffs
> -----
> 
>   tools/marvin/marvin/integration/lib/base.py 6e49ae5 
> 
> Diff: https://reviews.apache.org/r/12897/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Girish Shilamkar
> 
>

Re: Review Request 12897: CLOUDSTACK-3594: Fix regression in Affinity Groups tests

Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12897/#review23765
-----------------------------------------------------------

Ship it!


Ship It!

- Prasanna Santhanam


On July 24, 2013, 10:51 a.m., Girish Shilamkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12897/
> -----------------------------------------------------------
> 
> (Updated July 24, 2013, 10:51 a.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Bugs: CLOUDSTACK-3594
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> One of the patches introduced a regression where account
> and domainid parameters were changed. Therefore Affinity
> Groups for those accounts were not found and tests failed.
> 
> 
> Diffs
> -----
> 
>   tools/marvin/marvin/integration/lib/base.py 6e49ae5 
> 
> Diff: https://reviews.apache.org/r/12897/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Girish Shilamkar
> 
>