[dev] [jira] [Commented] (LIBCLOUD-123) Driver Updates

["Tomaz Muraus (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LIBCLOUD-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13133622#comment-13133622 ] 

Tomaz Muraus commented on LIBCLOUD-123:
---------------------------------------

I've merged your patch into trunk with a some modifications. I removed trailing comma and fixed attribute alignment in some places.

Only place where we should use a trailing comma is a tuple with a single element.

There were also some functional problems / bugs:

- an undefined import in the OpenStack driver. You did "import libcloud.utils" and then used "utils.find.." instead of doing "libcloud.utils.find..". I changed it to do "from libcloud.utils import find..."

- missing parenthesis in some places where doing string interpolation in the Opsource driver 

- parse_error in Opsource driver was accessing an undefined "body" variable - you changed the if statement order

- you (accidentally?) removed ex_list_networks method in the Opsource driver

- return self.body in OpSource parse_body was unreachable

Next time please make sure at least the tests pass before attaching a patch.

Thanks,
Tomaz
                
> Driver Updates
> --------------
>
>                 Key: LIBCLOUD-123
>                 URL: https://issues.apache.org/jira/browse/LIBCLOUD-123
>             Project: Libcloud
>          Issue Type: Improvement
>          Components: Compute
>    Affects Versions: 0.6.0
>            Reporter: Hutson Betts
>            Priority: Minor
>              Labels: patch, style
>             Fix For: 0.6.0
>
>         Attachments: update.diff
>
>
> I modified the Opsource and OpenStack drivers to match in consistency with the OpenNebula driver. This also included changes to include httplib. I hope to extend that work later to other drivers, if the work is desired. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira