[GitHub] [spark] LuciferYang commented on pull request #41943: [SPARK-44376][BUILD] Fix maven build using scala 2.13 and Java 11 or later

["LuciferYang (via GitHub)" <gi...@apache.org>]

LuciferYang commented on PR #41943:
URL: https://github.com/apache/spark/pull/41943#issuecomment-1659721894

   @eejbyfeldt can we change to use `-release:8`?
   
   I have made the following changes based on your pr:
   1. upgrade `scala-maven-plugin` from 4.8.0 to 4.8.1
   2. change `-target:jvm-1.8` to `-release:8`, both line 2911 and line 3652
   
   then I test
   ```
   java -version
   openjdk version "17.0.8" 2023-07-18 LTS
   OpenJDK Runtime Environment Zulu17.44+15-CA (build 17.0.8+7-LTS)
   OpenJDK 64-Bit Server VM Zulu17.44+15-CA (build 17.0.8+7-LTS, mixed mode, sharing)
   
   ./build/mvn -DskipTests clean package   
    ./build/mvn clean compile -Pscala-2.13 
   ./build/mvn clean compile -Pscala-2.13
   ```
   
   Both Scala 2.12 and Scala 2.13 with Java 17 build successfully, and the `-release` always `8`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org