You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/02/15 22:07:55 UTC

[GitHub] [airflow] jhtimmins commented on pull request #21294: Adding missing login provider related methods from Flask-Appbuilder

jhtimmins commented on pull request #21294:
URL: https://github.com/apache/airflow/pull/21294#issuecomment-1040844812


   @aa3pankaj @potiuk The reason for copying FAB permission classes directly into Airflow is that it allowed us to dramatically simplify the code and standardize naming around Airflow's conventions, which helps minimize bugs and makes it easier to modify. The change also allowed for faster queries.
   
   This code change looks good. I agree that pinning FAB is the right move.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org