You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by xi...@apache.org on 2023/09/07 17:47:46 UTC

[nuttx] branch master updated: cxd56xx: rm sched_[un]lock

This is an automated email from the ASF dual-hosted git repository.

xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git


The following commit(s) were added to refs/heads/master by this push:
     new 83ba72e4b4 cxd56xx: rm sched_[un]lock
83ba72e4b4 is described below

commit 83ba72e4b4b1b68912fa4f0461404b45b6eb31c2
Author: hujun5 <hu...@xiaomi.com>
AuthorDate: Thu Sep 7 07:46:08 2023 +0800

    cxd56xx: rm sched_[un]lock
    
    According to the current implementation, "cxd56_cpu1siguninit" will only
    be called once during the NuttX startup phase,
    and it won't involve scenarios of multi-threaded concurrent access.
    
    Signed-off-by: hujun5 <hu...@xiaomi.com>
---
 arch/arm/src/cxd56xx/cxd56_cpu1signal.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/arch/arm/src/cxd56xx/cxd56_cpu1signal.c b/arch/arm/src/cxd56xx/cxd56_cpu1signal.c
index b161fb8c86..da7fad430e 100644
--- a/arch/arm/src/cxd56xx/cxd56_cpu1signal.c
+++ b/arch/arm/src/cxd56xx/cxd56_cpu1signal.c
@@ -169,8 +169,6 @@ int cxd56_cpu1siginit(uint8_t sigtype, void *data)
       return -ENODEV;
     }
 
-  sched_lock();
-
   if (priv->sigtype[sigtype].use)
     {
       ret = -EBUSY;
@@ -188,8 +186,6 @@ int cxd56_cpu1siginit(uint8_t sigtype, void *data)
 
   priv->ndev++;
 
-  sched_unlock();
-
   cxd56_iccinit(CXD56_PROTO_GNSS);
 
   ret = cxd56_iccinitmsg(CXD56CPU1_CPUID);
@@ -221,7 +217,6 @@ err0:
   return ret;
 
 err1:
-  sched_unlock();
   return ret;
 }
 
@@ -236,12 +231,9 @@ int cxd56_cpu1siguninit(uint8_t sigtype)
       return -ENODEV;
     }
 
-  sched_lock();
-
   if (!priv->sigtype[sigtype].use)
     {
       ret = -EBUSY;
-      sched_unlock();
       return ret;
     }
 
@@ -258,8 +250,6 @@ int cxd56_cpu1siguninit(uint8_t sigtype)
   pid             = priv->workerpid;
   priv->workerpid = INVALID_PROCESS_ID;
 
-  sched_unlock();
-
   ret = kthread_delete(pid);
 
   if (ret)