You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Timothy Chen <tn...@apache.org> on 2014/06/13 21:55:08 UTC
Re: Review Request 22519: Add grace period to health check and move health
check into TaskInfo
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22519/
-----------------------------------------------------------
(Updated June 13, 2014, 7:55 p.m.)
Review request for mesos and Niklas Nielsen.
Repository: mesos-git
Description
-------
Add grace period to health check and move health check into TaskInfo
Diffs (updated)
-----
include/mesos/mesos.proto 102289b
Diff: https://reviews.apache.org/r/22519/diff/
Testing
-------
make check
Thanks,
Timothy Chen
Re: Review Request 22519: Add grace period to health check and move health
check into TaskInfo
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22519/#review45653
-----------------------------------------------------------
Ship it!
Ship It!
- Niklas Nielsen
On June 13, 2014, 12:55 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22519/
> -----------------------------------------------------------
>
> (Updated June 13, 2014, 12:55 p.m.)
>
>
> Review request for mesos and Niklas Nielsen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Add grace period to health check and move health check into TaskInfo
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 102289b
>
> Diff: https://reviews.apache.org/r/22519/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 22519: Add grace period to health check and move health
check into TaskInfo
Posted by Niklas Nielsen <ni...@qni.dk>.
> On June 13, 2014, 2:31 p.m., Timothy Chen wrote:
> > include/mesos/mesos.proto, line 185
> > <https://reviews.apache.org/r/22519/diff/3/?file=609537#file609537line185>
> >
> > Ah yes I thought I fixed the typo but somehow it wasn't. Good catch.
Mind marking these issues as fixed and the RR as submitted? :-)
- Niklas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22519/#review45658
-----------------------------------------------------------
On June 13, 2014, 12:55 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22519/
> -----------------------------------------------------------
>
> (Updated June 13, 2014, 12:55 p.m.)
>
>
> Review request for mesos and Niklas Nielsen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Add grace period to health check and move health check into TaskInfo
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 102289b
>
> Diff: https://reviews.apache.org/r/22519/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 22519: Add grace period to health check and move health
check into TaskInfo
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22519/#review45658
-----------------------------------------------------------
include/mesos/mesos.proto
<https://reviews.apache.org/r/22519/#comment80562>
Ah yes I thought I fixed the typo but somehow it wasn't. Good catch.
- Timothy Chen
On June 13, 2014, 7:55 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22519/
> -----------------------------------------------------------
>
> (Updated June 13, 2014, 7:55 p.m.)
>
>
> Review request for mesos and Niklas Nielsen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Add grace period to health check and move health check into TaskInfo
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 102289b
>
> Diff: https://reviews.apache.org/r/22519/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 22519: Add grace period to health check and move health
check into TaskInfo
Posted by Bernardo Gomez Palacio <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22519/#review45656
-----------------------------------------------------------
include/mesos/mesos.proto
<https://reviews.apache.org/r/22519/#comment80560>
Shouldn't grade_period_seconds be grace_period_seconds?
- Bernardo Gomez Palacio
On June 13, 2014, 7:55 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22519/
> -----------------------------------------------------------
>
> (Updated June 13, 2014, 7:55 p.m.)
>
>
> Review request for mesos and Niklas Nielsen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Add grace period to health check and move health check into TaskInfo
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 102289b
>
> Diff: https://reviews.apache.org/r/22519/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>