You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@activemq.apache.org by scop <gi...@git.apache.org> on 2015/07/21 18:45:52 UTC

[GitHub] activemq-artemis pull request: STOMP encoding improvements, cleanu...

GitHub user scop opened a pull request:

    https://github.com/apache/activemq-artemis/pull/89

    STOMP encoding improvements, cleanups

    This is the PR I mentioned in #87. I managed to run the tests with IDEA.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/scop/activemq-artemis stomp-encode

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/89.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #89
    
----
commit 0b3a64c5e8669b7aa8eacd5154119e86b12c4613
Author: Ville Skyttä <vi...@iki.fi>
Date:   2015-07-21T16:04:08Z

    Auto-set content-length to STOMP 1.0 frames
    
    As recommended by the 1.0 spec.

commit 615a9881b501586ba787666fc831a8e4f988d1cc
Author: Ville Skyttä <vi...@iki.fi>
Date:   2015-07-21T16:06:40Z

    Use base implementation for STOMP 1.1+ toActiveMQBuffer

commit 214a1dc1ebd90806c7ba20762ee672ec11e4eb22
Author: Ville Skyttä <vi...@iki.fi>
Date:   2015-07-21T16:08:41Z

    Use StringBuilder instead of StringBuffer on STOMP encode

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request: STOMP encoding improvements, cleanu...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/89


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request: STOMP encoding improvements, cleanu...

Posted by clebertsuconic <gi...@git.apache.org>.

Github user clebertsuconic commented on the pull request:

    https://github.com/apache/activemq-artemis/pull/89#issuecomment-123474609
  
    Alright!!! simple change and more polymorphic than my change.. merging it!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---