You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Pascal Schumacher (JIRA)" <ji...@apache.org> on 2016/08/30 19:55:20 UTC

[jira] [Resolved] (LANG-1262) CompareToBuilder.append(Object,Object,Comparator) method is too big to be inlined

     [ https://issues.apache.org/jira/browse/LANG-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pascal Schumacher resolved LANG-1262.
-------------------------------------
       Resolution: Fixed
         Assignee: Pascal Schumacher
    Fix Version/s: 3.5

Done as suggested. Thanks for reporting!

> CompareToBuilder.append(Object,Object,Comparator) method is too big to be inlined
> ---------------------------------------------------------------------------------
>
>                 Key: LANG-1262
>                 URL: https://issues.apache.org/jira/browse/LANG-1262
>             Project: Commons Lang
>          Issue Type: Bug
>          Components: lang.builder.*
>    Affects Versions: 3.4
>            Reporter: Ruslan Cheremin
>            Assignee: Pascal Schumacher
>             Fix For: 3.5
>
>
> Issue is the same as in LANG-1218: CompareToBuilder.append(Object,Object,Comparator) is quite big, due to in-place arrays processing, and thus breaching inlining threshold (325 bytecodes):
> {noformat}
> ....
> o.a.c.l.b.CompareToBuilder::append (346 bytes)   hot method too big
> ....
> {noformat}
> This prevents CompareToBuilder object itself from being scalarized.
> Fix may be the same, as in LANG-1218: extract arrays processing into separate method.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)