You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2023/06/12 17:41:56 UTC
[kudu-CR](branch-1.17.x) [webserver] handlers for application/octet-stream content
Hello Zoltan Chovan, Attila Bukor, Kudu Jenkins,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/20046
to review the following change.
Change subject: [webserver] handlers for application/octet-stream content
......................................................................
[webserver] handlers for application/octet-stream content
This patch introduces application/octet-stream (a.k.a. binary data)
handlers for the embedded web server.
As a particular application of the newly introduced feature, this patch
also adds /ipki-ca-cert-der endpoint to the master's embedded webserver.
It outputs the same IPKI CA certificate as the /ipki-ca-cert and
/ipki-ca-cert-pem endpoints, but in DER format. This will be used
in a changelist where Java client needs to import Kudu cluster's CA
certificate into its trust chain when using JWT for authentication.
As it turns out, the 'standard' security providers for Java runtime
don't provide enough functionality to conveniently work with X509 in PEM
format (yes, there is BouncyCastle, but I'm not sure we want to
introduce such a dependency just for the convenience of working with
certificates in PEM format at a few call sites in the Java client).
To cover the newly introduced functionality, an extra test has been added
into security-itest and PeriodicWebUIChecker has been updated.
Change-Id: I894d8e00943617cb80ec5aa14a15db3448ad9252
Reviewed-on: http://gerrit.cloudera.org:8080/20023
Tested-by: Kudu Jenkins
Reviewed-by: Zoltan Chovan <zc...@cloudera.com>
Reviewed-by: Attila Bukor <ab...@apache.org>
(cherry picked from commit 1e7d1b3d117ca137bdce3d2ec549416d242bdd02)
---
M src/kudu/integration-tests/security-itest.cc
M src/kudu/master/master_path_handlers.cc
M src/kudu/master/master_path_handlers.h
M src/kudu/mini-cluster/webui_checker.h
M src/kudu/server/webserver.cc
M src/kudu/server/webserver.h
M src/kudu/util/web_callback_registry.h
7 files changed, 154 insertions(+), 28 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/46/20046/1
--
To view, visit http://gerrit.cloudera.org:8080/20046
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I894d8e00943617cb80ec5aa14a15db3448ad9252
Gerrit-Change-Number: 20046
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR](branch-1.17.x) [webserver] handlers for application/octet-stream content
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20046 )
Change subject: [webserver] handlers for application/octet-stream content
......................................................................
Patch Set 1: Verified+1
unrelated test failure (TSAN): TabletCopyClientBasicTestModes/TabletCopyClientBasicTest.TestDownloadBlockMayFail/1
--
To view, visit http://gerrit.cloudera.org:8080/20046
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I894d8e00943617cb80ec5aa14a15db3448ad9252
Gerrit-Change-Number: 20046
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 12 Jun 2023 19:39:49 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.17.x) [webserver] handlers for application/octet-stream content
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [webserver] handlers for application/octet-stream content
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/20046
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I894d8e00943617cb80ec5aa14a15db3448ad9252
Gerrit-Change-Number: 20046
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR](branch-1.17.x) [webserver] handlers for application/octet-stream content
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20046 )
Change subject: [webserver] handlers for application/octet-stream content
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/20046
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I894d8e00943617cb80ec5aa14a15db3448ad9252
Gerrit-Change-Number: 20046
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 13 Jun 2023 04:01:06 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.17.x) [webserver] handlers for application/octet-stream content
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20046 )
Change subject: [webserver] handlers for application/octet-stream content
......................................................................
[webserver] handlers for application/octet-stream content
This patch introduces application/octet-stream (a.k.a. binary data)
handlers for the embedded web server.
As a particular application of the newly introduced feature, this patch
also adds /ipki-ca-cert-der endpoint to the master's embedded webserver.
It outputs the same IPKI CA certificate as the /ipki-ca-cert and
/ipki-ca-cert-pem endpoints, but in DER format. This will be used
in a changelist where Java client needs to import Kudu cluster's CA
certificate into its trust chain when using JWT for authentication.
As it turns out, the 'standard' security providers for Java runtime
don't provide enough functionality to conveniently work with X509 in PEM
format (yes, there is BouncyCastle, but I'm not sure we want to
introduce such a dependency just for the convenience of working with
certificates in PEM format at a few call sites in the Java client).
To cover the newly introduced functionality, an extra test has been added
into security-itest and PeriodicWebUIChecker has been updated.
Change-Id: I894d8e00943617cb80ec5aa14a15db3448ad9252
Reviewed-on: http://gerrit.cloudera.org:8080/20023
Tested-by: Kudu Jenkins
Reviewed-by: Zoltan Chovan <zc...@cloudera.com>
Reviewed-by: Attila Bukor <ab...@apache.org>
(cherry picked from commit 1e7d1b3d117ca137bdce3d2ec549416d242bdd02)
Reviewed-on: http://gerrit.cloudera.org:8080/20046
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Yingchun Lai <la...@apache.org>
---
M src/kudu/integration-tests/security-itest.cc
M src/kudu/master/master_path_handlers.cc
M src/kudu/master/master_path_handlers.h
M src/kudu/mini-cluster/webui_checker.h
M src/kudu/server/webserver.cc
M src/kudu/server/webserver.h
M src/kudu/util/web_callback_registry.h
7 files changed, 154 insertions(+), 28 deletions(-)
Approvals:
Alexey Serbin: Verified
Yingchun Lai: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/20046
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I894d8e00943617cb80ec5aa14a15db3448ad9252
Gerrit-Change-Number: 20046
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>