You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/02/07 13:18:43 UTC
[GitHub] [arrow] projjal opened a new pull request #12351: ARROW-15598: [C++][Gandiva] Avoid using hardcoded raw pointer addresses in generated code
projjal opened a new pull request #12351:
URL: https://github.com/apache/arrow/pull/12351
This change fixes sporadic crashes that happened with certain expression when caching only the generated object code. The crash was happening because the generated code contained raw hardcoded pointer addresses during building certain expressions, and when using this cache entry during subsequent times these addresses point to then invalid memory.
This change :
* introduces an array of pointers that holds the pointers to function holders and in holders, that is filled up during the build stage and passed to the generated function during execution. The generated IR contains indices to this array instead of hardcoded addresses.
* includes string literal in the generated IR as a global variable instead of a raw pointer address to the process memory.
* removes the flag introduced in 4e1c79e
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12351: ARROW-15598: [C++][Gandiva] Avoid using hardcoded raw pointer addresses in generated code
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12351:
URL: https://github.com/apache/arrow/pull/12351#issuecomment-1039069459
Benchmark runs are scheduled for baseline = 5f590e9e64d880e2290dacc76ac85b4cd0d5f40a and contender = 269f5d2d42259971e291bd61dadc4cff4d969273. 269f5d2d42259971e291bd61dadc4cff4d969273 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Failed] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/19911ada73204959842583728b7ef2cd...71506c361ba24423913189a82053e74b/)
[Failed] [test-mac-arm](https://conbench.ursa.dev/compare/runs/2f6ecf3f69e543d8b6038e9f4e2d3ec7...a096e92dfcca4a7aa3eb55141fd2470b/)
[Failed] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/9b014fe85302422c8b34904a8ec1e3ae...c4462667bc794d889297f5bbf5951ebd/)
[Failed] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/2d6e834a49ac45a3bd27e9c812aebaab...9e637514397f47c68ef3a9f24517e761/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a change in pull request #12351: ARROW-15598: [C++][Gandiva] Avoid using hardcoded raw pointer addresses in generated code
Posted by GitBox <gi...@apache.org>.
pitrou commented on a change in pull request #12351:
URL: https://github.com/apache/arrow/pull/12351#discussion_r802884659
##########
File path: cpp/src/gandiva/expr_decomposer.cc
##########
@@ -190,21 +192,25 @@ Status ExprDecomposer::Visit(const InExpressionNode<gandiva::DecimalScalar128>&
/* In always outputs valid results, so no validity dex */
auto value_dex = std::make_shared<InExprDex<gandiva::DecimalScalar128>>(
args, node.values(), node.get_precision(), node.get_scale());
+ int holder_idx = annotator_.AddHolderPointer(value_dex->in_holder().get());
+ value_dex->set_holder_idx(holder_idx);
result_ = std::make_shared<ValueValidityPair>(value_dex);
return Status::OK();
}
-#define MAKE_VISIT_IN(ctype) \
- Status ExprDecomposer::Visit(const InExpressionNode<ctype>& node) { \
- /* decompose the children. */ \
- std::vector<ValueValidityPairPtr> args; \
- auto status = node.eval_expr()->Accept(*this); \
- ARROW_RETURN_NOT_OK(status); \
- args.push_back(result()); \
- /* In always outputs valid results, so no validity dex */ \
- auto value_dex = std::make_shared<InExprDex<ctype>>(args, node.values()); \
- result_ = std::make_shared<ValueValidityPair>(value_dex); \
- return Status::OK(); \
+#define MAKE_VISIT_IN(ctype) \
+ Status ExprDecomposer::Visit(const InExpressionNode<ctype>& node) { \
Review comment:
Can we avoid a long C macro here? For example:
```c++
template <typename ctype>
Status ExprDecomposer::VisitExprGeneric(const InExpressionNode<ctype>& node) {
/* decompose the children. */
}
Status ExprDecomposer::Visit(const InExpressionNode<int32_t>& node) {
return VisitExprGeneric(node);
}
// etc.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] projjal commented on a change in pull request #12351: ARROW-15598: [C++][Gandiva] Avoid using hardcoded raw pointer addresses in generated code
Posted by GitBox <gi...@apache.org>.
projjal commented on a change in pull request #12351:
URL: https://github.com/apache/arrow/pull/12351#discussion_r804556403
##########
File path: cpp/src/gandiva/annotator.h
##########
@@ -47,6 +47,13 @@ class GANDIVA_EXPORT Annotator {
/// Returns the index of the bitmap in the list of local bitmaps.
int AddLocalBitMap() { return local_bitmap_count_++; }
+ /// Add a pointer to function holder or in holder
+ /// Returns the index of the holder in the holder_pointers vector
+ int AddHolderPointer(void* holder);
+
+ /// Return a pointer to the underlying array containing the holder pointers
+ void** GetHolderPointersArray() { return holder_pointers_.data(); }
Review comment:
Yes. This is only called during execution after expr decomposition when the holder pointers are added. Added a note in the comment explaining the same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] projjal commented on pull request #12351: ARROW-15598: [C++][Gandiva] Avoid using hardcoded raw pointer addresses in generated code
Posted by GitBox <gi...@apache.org>.
projjal commented on pull request #12351:
URL: https://github.com/apache/arrow/pull/12351#issuecomment-1036098840
Undid the earlier change of removing the GANDIVA_ENABLE_OBJECT_CODE_CACHE flag since that code path still does a lot of unnecessary work hampering performance, which I will refactor in another PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] projjal commented on a change in pull request #12351: ARROW-15598: [C++][Gandiva] Avoid using hardcoded raw pointer addresses in generated code
Posted by GitBox <gi...@apache.org>.
projjal commented on a change in pull request #12351:
URL: https://github.com/apache/arrow/pull/12351#discussion_r804556521
##########
File path: cpp/src/gandiva/expr_decomposer.cc
##########
@@ -190,21 +192,25 @@ Status ExprDecomposer::Visit(const InExpressionNode<gandiva::DecimalScalar128>&
/* In always outputs valid results, so no validity dex */
auto value_dex = std::make_shared<InExprDex<gandiva::DecimalScalar128>>(
args, node.values(), node.get_precision(), node.get_scale());
+ int holder_idx = annotator_.AddHolderPointer(value_dex->in_holder().get());
+ value_dex->set_holder_idx(holder_idx);
result_ = std::make_shared<ValueValidityPair>(value_dex);
return Status::OK();
}
-#define MAKE_VISIT_IN(ctype) \
- Status ExprDecomposer::Visit(const InExpressionNode<ctype>& node) { \
- /* decompose the children. */ \
- std::vector<ValueValidityPairPtr> args; \
- auto status = node.eval_expr()->Accept(*this); \
- ARROW_RETURN_NOT_OK(status); \
- args.push_back(result()); \
- /* In always outputs valid results, so no validity dex */ \
- auto value_dex = std::make_shared<InExprDex<ctype>>(args, node.values()); \
- result_ = std::make_shared<ValueValidityPair>(value_dex); \
- return Status::OK(); \
+#define MAKE_VISIT_IN(ctype) \
+ Status ExprDecomposer::Visit(const InExpressionNode<ctype>& node) { \
Review comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a change in pull request #12351: ARROW-15598: [C++][Gandiva] Avoid using hardcoded raw pointer addresses in generated code
Posted by GitBox <gi...@apache.org>.
pitrou commented on a change in pull request #12351:
URL: https://github.com/apache/arrow/pull/12351#discussion_r802880805
##########
File path: cpp/src/gandiva/annotator.h
##########
@@ -47,6 +47,13 @@ class GANDIVA_EXPORT Annotator {
/// Returns the index of the bitmap in the list of local bitmaps.
int AddLocalBitMap() { return local_bitmap_count_++; }
+ /// Add a pointer to function holder or in holder
+ /// Returns the index of the holder in the holder_pointers vector
+ int AddHolderPointer(void* holder);
+
+ /// Return a pointer to the underlying array containing the holder pointers
+ void** GetHolderPointersArray() { return holder_pointers_.data(); }
Review comment:
Just one question: `holder_pointers_` cannot be resized any further? Otherwise, this pointer could become invalid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12351: ARROW-15598: [C++][Gandiva] Avoid using hardcoded raw pointer addresses in generated code
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12351:
URL: https://github.com/apache/arrow/pull/12351#issuecomment-1039069459
Benchmark runs are scheduled for baseline = 5f590e9e64d880e2290dacc76ac85b4cd0d5f40a and contender = 269f5d2d42259971e291bd61dadc4cff4d969273. 269f5d2d42259971e291bd61dadc4cff4d969273 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/19911ada73204959842583728b7ef2cd...71506c361ba24423913189a82053e74b/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/2f6ecf3f69e543d8b6038e9f4e2d3ec7...a096e92dfcca4a7aa3eb55141fd2470b/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/9b014fe85302422c8b34904a8ec1e3ae...c4462667bc794d889297f5bbf5951ebd/)
[Failed] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/2d6e834a49ac45a3bd27e9c812aebaab...9e637514397f47c68ef3a9f24517e761/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pravindra closed pull request #12351: ARROW-15598: [C++][Gandiva] Avoid using hardcoded raw pointer addresses in generated code
Posted by GitBox <gi...@apache.org>.
pravindra closed pull request #12351:
URL: https://github.com/apache/arrow/pull/12351
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12351: ARROW-15598: [C++][Gandiva] Avoid using hardcoded raw pointer addresses in generated code
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12351:
URL: https://github.com/apache/arrow/pull/12351#issuecomment-1031461144
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12351: ARROW-15598: [C++][Gandiva] Avoid using hardcoded raw pointer addresses in generated code
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12351:
URL: https://github.com/apache/arrow/pull/12351#issuecomment-1039069459
Benchmark runs are scheduled for baseline = 5f590e9e64d880e2290dacc76ac85b4cd0d5f40a and contender = 269f5d2d42259971e291bd61dadc4cff4d969273. 269f5d2d42259971e291bd61dadc4cff4d969273 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/19911ada73204959842583728b7ef2cd...71506c361ba24423913189a82053e74b/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/2f6ecf3f69e543d8b6038e9f4e2d3ec7...a096e92dfcca4a7aa3eb55141fd2470b/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/9b014fe85302422c8b34904a8ec1e3ae...c4462667bc794d889297f5bbf5951ebd/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/2d6e834a49ac45a3bd27e9c812aebaab...9e637514397f47c68ef3a9f24517e761/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12351: ARROW-15598: [C++][Gandiva] Avoid using hardcoded raw pointer addresses in generated code
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12351:
URL: https://github.com/apache/arrow/pull/12351#issuecomment-1039069459
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12351: ARROW-15598: [C++][Gandiva] Avoid using hardcoded raw pointer addresses in generated code
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12351:
URL: https://github.com/apache/arrow/pull/12351#issuecomment-1039069459
Benchmark runs are scheduled for baseline = 5f590e9e64d880e2290dacc76ac85b4cd0d5f40a and contender = 269f5d2d42259971e291bd61dadc4cff4d969273. 269f5d2d42259971e291bd61dadc4cff4d969273 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/19911ada73204959842583728b7ef2cd...71506c361ba24423913189a82053e74b/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/2f6ecf3f69e543d8b6038e9f4e2d3ec7...a096e92dfcca4a7aa3eb55141fd2470b/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/9b014fe85302422c8b34904a8ec1e3ae...c4462667bc794d889297f5bbf5951ebd/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/2d6e834a49ac45a3bd27e9c812aebaab...9e637514397f47c68ef3a9f24517e761/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #12351: ARROW-15598: [C++][Gandiva] Avoid using hardcoded raw pointer addresses in generated code
Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #12351:
URL: https://github.com/apache/arrow/pull/12351#issuecomment-1039069459
Benchmark runs are scheduled for baseline = 5f590e9e64d880e2290dacc76ac85b4cd0d5f40a and contender = 269f5d2d42259971e291bd61dadc4cff4d969273. 269f5d2d42259971e291bd61dadc4cff4d969273 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/19911ada73204959842583728b7ef2cd...71506c361ba24423913189a82053e74b/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/2f6ecf3f69e543d8b6038e9f4e2d3ec7...a096e92dfcca4a7aa3eb55141fd2470b/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/9b014fe85302422c8b34904a8ec1e3ae...c4462667bc794d889297f5bbf5951ebd/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/2d6e834a49ac45a3bd27e9c812aebaab...9e637514397f47c68ef3a9f24517e761/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12351: ARROW-15598: [C++][Gandiva] Avoid using hardcoded raw pointer addresses in generated code
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12351:
URL: https://github.com/apache/arrow/pull/12351#issuecomment-1039069459
Benchmark runs are scheduled for baseline = 5f590e9e64d880e2290dacc76ac85b4cd0d5f40a and contender = 269f5d2d42259971e291bd61dadc4cff4d969273. 269f5d2d42259971e291bd61dadc4cff4d969273 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/19911ada73204959842583728b7ef2cd...71506c361ba24423913189a82053e74b/)
[Finished :arrow_down:0.09% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/2f6ecf3f69e543d8b6038e9f4e2d3ec7...a096e92dfcca4a7aa3eb55141fd2470b/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/9b014fe85302422c8b34904a8ec1e3ae...c4462667bc794d889297f5bbf5951ebd/)
[Finished :arrow_down:0.39% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/2d6e834a49ac45a3bd27e9c812aebaab...9e637514397f47c68ef3a9f24517e761/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12351: ARROW-15598: [C++][Gandiva] Avoid using hardcoded raw pointer addresses in generated code
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12351:
URL: https://github.com/apache/arrow/pull/12351#issuecomment-1039069459
Benchmark runs are scheduled for baseline = 5f590e9e64d880e2290dacc76ac85b4cd0d5f40a and contender = 269f5d2d42259971e291bd61dadc4cff4d969273. 269f5d2d42259971e291bd61dadc4cff4d969273 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/19911ada73204959842583728b7ef2cd...71506c361ba24423913189a82053e74b/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/2f6ecf3f69e543d8b6038e9f4e2d3ec7...a096e92dfcca4a7aa3eb55141fd2470b/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/9b014fe85302422c8b34904a8ec1e3ae...c4462667bc794d889297f5bbf5951ebd/)
[Finished :arrow_down:0.39% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/2d6e834a49ac45a3bd27e9c812aebaab...9e637514397f47c68ef3a9f24517e761/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12351: ARROW-15598: [C++][Gandiva] Avoid using hardcoded raw pointer addresses in generated code
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12351:
URL: https://github.com/apache/arrow/pull/12351#issuecomment-1039069459
Benchmark runs are scheduled for baseline = 5f590e9e64d880e2290dacc76ac85b4cd0d5f40a and contender = 269f5d2d42259971e291bd61dadc4cff4d969273. 269f5d2d42259971e291bd61dadc4cff4d969273 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/19911ada73204959842583728b7ef2cd...71506c361ba24423913189a82053e74b/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/2f6ecf3f69e543d8b6038e9f4e2d3ec7...a096e92dfcca4a7aa3eb55141fd2470b/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/9b014fe85302422c8b34904a8ec1e3ae...c4462667bc794d889297f5bbf5951ebd/)
[Failed] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/2d6e834a49ac45a3bd27e9c812aebaab...9e637514397f47c68ef3a9f24517e761/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12351: ARROW-15598: [C++][Gandiva] Avoid using hardcoded raw pointer addresses in generated code
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12351:
URL: https://github.com/apache/arrow/pull/12351#issuecomment-1039069459
Benchmark runs are scheduled for baseline = 5f590e9e64d880e2290dacc76ac85b4cd0d5f40a and contender = 269f5d2d42259971e291bd61dadc4cff4d969273. 269f5d2d42259971e291bd61dadc4cff4d969273 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/19911ada73204959842583728b7ef2cd...71506c361ba24423913189a82053e74b/)
[Finished :arrow_down:0.09% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/2f6ecf3f69e543d8b6038e9f4e2d3ec7...a096e92dfcca4a7aa3eb55141fd2470b/)
[Failed :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/9b014fe85302422c8b34904a8ec1e3ae...c4462667bc794d889297f5bbf5951ebd/)
[Finished :arrow_down:0.39% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/2d6e834a49ac45a3bd27e9c812aebaab...9e637514397f47c68ef3a9f24517e761/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org