[GitHub] [iceberg] nastra commented on a diff in pull request #5836: Cache dropStats result for ManifestReader iterator

[GitBox <gi...@apache.org>]

nastra commented on code in PR #5836:
URL: https://github.com/apache/iceberg/pull/5836#discussion_r984257438


##########
core/src/main/java/org/apache/iceberg/ManifestReader.java:
##########
@@ -268,8 +270,7 @@ CloseableIterable<ManifestEntry<F>> liveEntries() {
   /** @return an Iterator of DataFile. Makes defensive copies of files before returning */
   @Override
   public CloseableIterator<F> iterator() {
-    return CloseableIterable.transform(liveEntries(), e -> e.file().copy(!dropStats(columns)))
-        .iterator();
+    return CloseableIterable.transform(liveEntries(), e -> e.file().copy(!dropStats)).iterator();

Review Comment:
   good catch, I should have definitely checked the surrounding code and not just the diff on the PR. Given that tests also didn't catch that, I think it would be a good idea to try and add a test for this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org