[GitHub] [incubator-superset] adam-stasiak commented on a change in pull request #11254: chore: Added data-test attributes for testing

[GitBox <gi...@apache.org>]

adam-stasiak commented on a change in pull request #11254:
URL: https://github.com/apache/incubator-superset/pull/11254#discussion_r504945526



##########
File path: superset-frontend/src/components/FaveStar.tsx
##########
@@ -46,7 +46,12 @@ export default class FaveStar extends React.PureComponent<FaveStarProps> {
           label="fave-unfave"
           tooltip={t('Click to favorite/unfavorite')}
         >
-          <a href="#" onClick={this.onClick} className="fave-unfave-icon">
+          <a
+            href="#"
+            onClick={this.onClick.bind(this)}

Review comment:
       yes - bad rebase




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org