You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/04/01 07:20:04 UTC

[GitHub] [pulsar] Jason918 opened a new pull request #14980: [fix][client] ConsumerBuilderImpl can not set null to deadLetterPolicy.

Jason918 opened a new pull request #14980:
URL: https://github.com/apache/pulsar/pull/14980


   
   ### Motivation
   
   `ConsumerBuilderImpl` can not set null to deadLetterPolicy if it's already assigned a non-null value.
   
   
   ### Modifications
   
   Calls `conf.setDeadLetterPolicy` if `deadLetterPolicy` is null.
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   This change added tests and can be verified as follows:
     - *Added new unit test  testNullDeadLetterPolicy*
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API: (no)
     - The schema: (no)
     - The default values of configurations: (no)
     - The wire protocol: (no)
     - The rest endpoints: (no)
     - The admin cli options: (no)
     - Anything that affects deployment: (no)
   
   ### Documentation
   
   Check the box below and label this PR (if you have committer privilege).
   
   Need to update docs? 
     
   - [x] `no-need-doc` 
   bug fix
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] RobertIndie merged pull request #14980: [fix][client] ConsumerBuilderImpl can not set null to deadLetterPolicy.

Posted by GitBox <gi...@apache.org>.
RobertIndie merged pull request #14980:
URL: https://github.com/apache/pulsar/pull/14980


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org