You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by astroshim <gi...@git.apache.org> on 2016/09/16 15:59:11 UTC
[GitHub] zeppelin pull request #1431: [ZEPPELIN-1446] Fix broken layout of `Create ne...
GitHub user astroshim opened a pull request:
https://github.com/apache/zeppelin/pull/1431
[ZEPPELIN-1446] Fix broken layout of `Create new interpreter` UI.
### What is this PR for?
This PR fixes broken layout of `Create new interpreter` UI.
### What type of PR is it?
Bug Fix
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1446
### How should this be tested?
- Try to create new interpreter on the Interpreters menu.
### Screenshots (if appropriate)
- before
- after
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/astroshim/zeppelin ZEPPELIN-1446
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1431.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1431
----
commit 5f0a461a3ebf81a36cb126cf216f3ed9a8231f9f
Author: astroshim <hs...@nflabs.com>
Date: 2016-09-16T15:53:21Z
fix align checkboxs.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1431: [ZEPPELIN-1446] Fix broken layout of `Create new inter...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1431
Tested LGTM
@astroshim Can you just rebase? That should make the CI green
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1431: [ZEPPELIN-1446] Fix broken layout of `Create ne...
Posted by astroshim <gi...@git.apache.org>.
GitHub user astroshim reopened a pull request:
https://github.com/apache/zeppelin/pull/1431
[ZEPPELIN-1446] Fix broken layout of `Create new interpreter` UI.
### What is this PR for?
This PR fixes broken layout of `Create new interpreter` UI.
### What type of PR is it?
Bug Fix
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1446
### How should this be tested?
- Try to create new interpreter on the Interpreters menu.
### Screenshots (if appropriate)
- before
- after
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/astroshim/zeppelin ZEPPELIN-1446
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1431.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1431
----
commit 5f0a461a3ebf81a36cb126cf216f3ed9a8231f9f
Author: astroshim <hs...@nflabs.com>
Date: 2016-09-16T15:53:21Z
fix align checkboxs.
commit 2d3ec76702c1127072f92489f5be333f7d85679f
Author: astroshim <hs...@nflabs.com>
Date: 2016-09-18T13:58:21Z
fix space
commit fada36bc7076c040bbc903fbb1708d5b448204d2
Author: astroshim <hs...@nflabs.com>
Date: 2016-09-19T07:42:47Z
fix spaces
commit 69cc1a076a725948a3c99e405a006cce78e81974
Author: astroshim <hs...@nflabs.com>
Date: 2016-09-21T12:56:10Z
Merge branch 'master' into ZEPPELIN-1446
commit 729215b67757de84d2f10b7c65e971de777a4f87
Author: astroshim <hs...@nflabs.com>
Date: 2016-09-22T05:41:03Z
Merge branch 'master' into ZEPPELIN-1446
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1431: [ZEPPELIN-1446] Fix broken layout of `Create new inter...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1431
@AhyoungRyu I was talking about the spacing below `Option`, `Properties` and `Dependencies`.
It stayed the same in your PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1431: [ZEPPELIN-1446] Fix broken layout of `Create new inter...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1431
@astroshim
Could we maybe try to keep the same spacing style as the interpreter edit?
#### Interpreter Edit:
#### Interpreter Create:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1431: [ZEPPELIN-1446] Fix broken layout of `Create new inter...
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1431
Thank you @AhyoungRyu and @corneadoug .
I just fixed space problems.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1431: [ZEPPELIN-1446] Fix broken layout of `Create ne...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1431
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1431: [ZEPPELIN-1446] Fix broken layout of `Create new inter...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1431
Merging if there is no more discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1431: [ZEPPELIN-1446] Fix broken layout of `Create new inter...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1431
CI is green now! LGTM \U0001f44d
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1431: [ZEPPELIN-1446] Fix broken layout of `Create new inter...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1431
@corneadoug Ah I got it. I'll do the same work as @astroshim did in my PR then :D
@astroshim Thanks for your quick response!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1431: [ZEPPELIN-1446] Fix broken layout of `Create new inter...
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1431
@AhyoungRyu Thank you for your kind review. I just fix the space.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1431: [ZEPPELIN-1446] Fix broken layout of `Create new inter...
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1431
I rebased but build failed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1431: [ZEPPELIN-1446] Fix broken layout of `Create new inter...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1431
@astroshim Good catch and looks better!
Can we make "A" and "B" have same space? Need more space to "A" :)
<img alt="screenshot" width="350px" src="https://cloud.githubusercontent.com/assets/10060731/18605350/976be588-7cca-11e6-9f61-33a3295563cc.png">
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1431: [ZEPPELIN-1446] Fix broken layout of `Create new inter...
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1431
re-build CI
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1431: [ZEPPELIN-1446] Fix broken layout of `Create new inter...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1431
@corneadoug Actually I did that work in [here](https://github.com/apache/zeppelin/pull/1434/files#diff-52843fa71a36ded9162a8bbb812459bcR234)... :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1431: [ZEPPELIN-1446] Fix broken layout of `Create new inter...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1431
@astroshim I think it was handled already in #1395. This is what I can see in the latest master branch :)
<img width="351" alt="screen shot 2016-09-17 at 11 11 36 am" src="https://cloud.githubusercontent.com/assets/10060731/18605251/a5a8a3f0-7cc7-11e6-9df3-41f28bdfae01.png">
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1431: [ZEPPELIN-1446] Fix broken layout of `Create ne...
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim closed the pull request at:
https://github.com/apache/zeppelin/pull/1431
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1431: [ZEPPELIN-1446] Fix broken layout of `Create new inter...
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1431
re-build CI
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1431: [ZEPPELIN-1446] Fix broken layout of `Create ne...
Posted by astroshim <gi...@git.apache.org>.
GitHub user astroshim reopened a pull request:
https://github.com/apache/zeppelin/pull/1431
[ZEPPELIN-1446] Fix broken layout of `Create new interpreter` UI.
### What is this PR for?
This PR fixes broken layout of `Create new interpreter` UI.
### What type of PR is it?
Bug Fix
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1446
### How should this be tested?
- Try to create new interpreter on the Interpreters menu.
### Screenshots (if appropriate)
- before
- after
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/astroshim/zeppelin ZEPPELIN-1446
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1431.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1431
----
commit 5f0a461a3ebf81a36cb126cf216f3ed9a8231f9f
Author: astroshim <hs...@nflabs.com>
Date: 2016-09-16T15:53:21Z
fix align checkboxs.
commit 2d3ec76702c1127072f92489f5be333f7d85679f
Author: astroshim <hs...@nflabs.com>
Date: 2016-09-18T13:58:21Z
fix space
commit fada36bc7076c040bbc903fbb1708d5b448204d2
Author: astroshim <hs...@nflabs.com>
Date: 2016-09-19T07:42:47Z
fix spaces
commit 69cc1a076a725948a3c99e405a006cce78e81974
Author: astroshim <hs...@nflabs.com>
Date: 2016-09-21T12:56:10Z
Merge branch 'master' into ZEPPELIN-1446
commit 729215b67757de84d2f10b7c65e971de777a4f87
Author: astroshim <hs...@nflabs.com>
Date: 2016-09-22T05:41:03Z
Merge branch 'master' into ZEPPELIN-1446
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1431: [ZEPPELIN-1446] Fix broken layout of `Create ne...
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim closed the pull request at:
https://github.com/apache/zeppelin/pull/1431
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---