[GitHub] [superset] rusackas commented on pull request #17792: feat: color consistency

[GitBox <gi...@apache.org>]

rusackas commented on pull request #17792:
URL: https://github.com/apache/superset/pull/17792#issuecomment-1017110764


   Upon first glance at the test environment, I see that the dashboard I looked at was... consistent! Hooray! 👏 
   
   I also see that this solution works by effectively populating the JSON metadata of the dashboard with ALL the colors of ALL the series. I guess that works. That seems to cause a few potential issues:
   
   1) I'm not sure if storing the metadata here might cause any potential bloat issues for the data, if there's some crazy number of series on the dashboard
   2) If you go and delete the series colors from the metadata, it doesn't seem like there's any way to get it back (adding more series, changing palettes, etc).
   
   Part of #2 is that I'm not sure what events trigger an update/refresh of the metadata. If there is such an event, I'd want to test and make sure that
   1) Changing palettes (or any other action) doesn't overwrite any user-added custom colors
   2) If you add a new series to two charts on a dashboard, those are also updated to match
   
   In other words, this seems to work at first glance, but there are a few implications that make me nervous about the approach. I'm curious what @zhaoyongjie and/or @villebro might think of it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org