You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/07/21 13:35:50 UTC

[GitHub] [airflow] pgagnon commented on a change in pull request #5488: [AIRFLOW-4880] Add success, failure and fail_on_empty params to SqlSensor

pgagnon commented on a change in pull request #5488: [AIRFLOW-4880] Add success, failure and fail_on_empty params to SqlSensor
URL: https://github.com/apache/airflow/pull/5488#discussion_r305618356
 
 

 ##########
 File path: airflow/sensors/sql_sensor.py
 ##########
 @@ -37,17 +42,27 @@ class SqlSensor(BaseSensorOperator):
     :type sql: str
     :param parameters: The parameters to render the SQL query with (optional).
     :type parameters: mapping or iterable
+    :param success: Success criteria for the sensor
+    :type: success: Optional<Iterable>
 
 Review comment:
   I would change this type to `Optional[Set]` for O(1) membership testing.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services