[GitHub] [superset] eschutho commented on a change in pull request #15785: feat: fetch UI specific reports

[GitBox <gi...@apache.org>]

eschutho commented on a change in pull request #15785:
URL: https://github.com/apache/superset/pull/15785#discussion_r673575118



##########
File path: superset-frontend/src/dashboard/reducers/dashboardState.js
##########
@@ -172,6 +173,12 @@ export default function dashboardStateReducer(state = {}, action) {
         fullSizeChartId: action.chartId,
       };
     },
+    [SET_DASHBOARD_REPORT]() {
+      return {
+        ...state,
+        report: action.report,

Review comment:
       do you need to put the report on the dashboard state if you have it also in the report state?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org