You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/11/01 16:33:38 UTC

[GitHub] [airflow] ashb commented on a change in pull request #6466: [AIRFLOW-5811] add metric for externally killed task count

ashb commented on a change in pull request #6466: [AIRFLOW-5811] add metric for externally killed task count
URL: https://github.com/apache/airflow/pull/6466#discussion_r341651795
 
 

 ##########
 File path: airflow/jobs/scheduler_job.py
 ##########
 @@ -1265,6 +1265,7 @@ def _process_executor_events(self, simple_dag_bag, session=None):
                     msg = ("Executor reports task instance {} finished ({}) "
                            "although the task says its {}. Was the task "
                            "killed externally?".format(ti, state, ti.state))
+                    Stats.incr('scheduler.tasks.killed_externally', 1, 1)
 
 Review comment:
   ```suggestion
                       Stats.incr('scheduler.tasks.killed_externally')
   ```
   
   Those two parameters are default.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services