[GitHub] mike-tutkowski commented on a change in pull request #2503: Support multiple volume access groups per compute cluster

[GitBox <gi...@apache.org>]

mike-tutkowski commented on a change in pull request #2503: Support multiple volume access groups per compute cluster
URL: https://github.com/apache/cloudstack/pull/2503#discussion_r185125254
 
 

 ##########
 File path: plugins/storage/volume/solidfire/src/main/java/org/apache/cloudstack/storage/datastore/util/SolidFireUtil.java
 ##########
 @@ -300,7 +311,7 @@ public static String getValue(String keyToMatch, String url, boolean throwExcept
     }
 
     public static String getSolidFireAccountName(String csAccountUuid, long csAccountId) {
-        return "CloudStack_" + csAccountUuid + "_" + csAccountId;
+        return SF_CS_ACCOUNT_PREFIX + csAccountUuid + "_" + csAccountId;
 
 Review comment:
   We could. The idea is really just to get the String representation of the SolidFire account for the CloudStack account in question. I'm definitely open to changing the method name, if you think it would help. The word "compile" is OK, but it typically invokes thoughts of a code compiler to me.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services