You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2015/01/22 22:14:26 UTC

Review Request 30190: Python logging fails with non-ascii characters in Mysql password

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30190/
-----------------------------------------------------------

Review request for Ambari and Vitalyi Brodetskyi.


Bugs: AMBARI-9283
    https://issues.apache.org/jira/browse/AMBARI-9283


Repository: ambari


Description
-------

Traceback (most recent call last):
File "/var/lib/ambari-agent/cache/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_server.py", line 63, in <module>
MysqlServer().execute()
File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", line 184, in execute
method(env)
File "/var/lib/ambari-agent/cache/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_server.py", line 34, in install
self.configure(env)
File "/var/lib/ambari-agent/cache/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_server.py", line 44, in configure
mysql_configure()
File "/var/lib/ambari-agent/cache/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_utils.py", line 34, in mysql_configure
mysql_users.mysql_adduser()
File "/var/lib/ambari-agent/cache/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_users.py", line 43, in mysql_adduser
path='/usr/sbin:/sbin:/usr/local/bin:/bin:/usr/bin'
File "/usr/lib/python2.6/site-packages/resource_management/core/base.py", line 148, in _init_
self.env.run()
File "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", line 134, in run
Logger.info_resource(resource)
File "/usr/lib/python2.6/site-packages/resource_management/core/logger.py", line 81, in info_resource
Logger.info(Logger.filter_text(Logger._get_resource_repr(resource)))
File "/usr/lib/python2.6/site-packages/resource_management/core/logger.py", line 104, in _get_resource_repr
return Logger.get_function_repr(repr(resource), resource.arguments)
UnicodeEncodeError: 'ascii' codec can't encode character u'\u0430' in position 77: ordinal not in range(128)


Diffs
-----

  ambari-agent/src/test/python/resource_management/TestDirectoryResource.py 0705922 
  ambari-agent/src/test/python/resource_management/TestExecuteHadoopResource.py 6ca6f36 
  ambari-agent/src/test/python/resource_management/TestFileResource.py 063de19 
  ambari-agent/src/test/python/resource_management/TestLinkResource.py 6a428b6 
  ambari-agent/src/test/python/resource_management/TestMonitorWebserverResource.py 65ada42 
  ambari-agent/src/test/python/resource_management/TestScript.py 9afaa39 
  ambari-agent/src/test/python/resource_management/TestUserResource.py f66b738 
  ambari-common/src/main/python/resource_management/core/base.py 52f1dff 

Diff: https://reviews.apache.org/r/30190/diff/


Testing
-------

[INFO] Reactor Summary:
[INFO] 
[INFO] Ambari Views ...................................... SUCCESS [8.313s]
[INFO] Ambari Server ..................................... SUCCESS [26.751s]
[INFO] Ambari Agent ...................................... SUCCESS [14.790s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 52.019s
[INFO] Finished at: Fri Jan 23 00:11:00 FET 2015
[INFO] Final Memory: 41M/458M
[INFO] ------------------------------------------------------------------------


Thanks,

Dmitro Lisnichenko


Re: Review Request 30190: Python logging fails with non-ascii characters in Mysql password

Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30190/#review69262
-----------------------------------------------------------

Ship it!


Ship It!

- Vitalyi Brodetskyi


On Jan. 22, 2015, 9:14 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30190/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2015, 9:14 p.m.)
> 
> 
> Review request for Ambari and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-9283
>     https://issues.apache.org/jira/browse/AMBARI-9283
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Traceback (most recent call last):
> File "/var/lib/ambari-agent/cache/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_server.py", line 63, in <module>
> MysqlServer().execute()
> File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", line 184, in execute
> method(env)
> File "/var/lib/ambari-agent/cache/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_server.py", line 34, in install
> self.configure(env)
> File "/var/lib/ambari-agent/cache/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_server.py", line 44, in configure
> mysql_configure()
> File "/var/lib/ambari-agent/cache/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_utils.py", line 34, in mysql_configure
> mysql_users.mysql_adduser()
> File "/var/lib/ambari-agent/cache/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_users.py", line 43, in mysql_adduser
> path='/usr/sbin:/sbin:/usr/local/bin:/bin:/usr/bin'
> File "/usr/lib/python2.6/site-packages/resource_management/core/base.py", line 148, in _init_
> self.env.run()
> File "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", line 134, in run
> Logger.info_resource(resource)
> File "/usr/lib/python2.6/site-packages/resource_management/core/logger.py", line 81, in info_resource
> Logger.info(Logger.filter_text(Logger._get_resource_repr(resource)))
> File "/usr/lib/python2.6/site-packages/resource_management/core/logger.py", line 104, in _get_resource_repr
> return Logger.get_function_repr(repr(resource), resource.arguments)
> UnicodeEncodeError: 'ascii' codec can't encode character u'\u0430' in position 77: ordinal not in range(128)
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/test/python/resource_management/TestDirectoryResource.py 0705922 
>   ambari-agent/src/test/python/resource_management/TestExecuteHadoopResource.py 6ca6f36 
>   ambari-agent/src/test/python/resource_management/TestFileResource.py 063de19 
>   ambari-agent/src/test/python/resource_management/TestLinkResource.py 6a428b6 
>   ambari-agent/src/test/python/resource_management/TestMonitorWebserverResource.py 65ada42 
>   ambari-agent/src/test/python/resource_management/TestScript.py 9afaa39 
>   ambari-agent/src/test/python/resource_management/TestUserResource.py f66b738 
>   ambari-common/src/main/python/resource_management/core/base.py 52f1dff 
> 
> Diff: https://reviews.apache.org/r/30190/diff/
> 
> 
> Testing
> -------
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Views ...................................... SUCCESS [8.313s]
> [INFO] Ambari Server ..................................... SUCCESS [26.751s]
> [INFO] Ambari Agent ...................................... SUCCESS [14.790s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 52.019s
> [INFO] Finished at: Fri Jan 23 00:11:00 FET 2015
> [INFO] Final Memory: 41M/458M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>