You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@chemistry.apache.org by "Manuel Jesús Recena Soto (JIRA)" <ji...@apache.org> on 2010/10/05 00:42:33 UTC

[jira] Created: (CMIS-256) Implement getObjectParents method

Implement getObjectParents method
---------------------------------

                 Key: CMIS-256
                 URL: https://issues.apache.org/jira/browse/CMIS-256
             Project: Chemistry
          Issue Type: Improvement
          Components: cmislib
            Reporter: Manuel Jesús Recena Soto


This method is very useful for building breadcrumbs.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CMIS-256) Implement getObjectParents method

Posted by "Manuel Jesús Recena Soto (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CMIS-256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917916#action_12917916 ] 

Manuel Jesús Recena Soto commented on CMIS-256:
-----------------------------------------------

Hi Florent,

Thanks for your answer.
So what I need is to implement getParent for cmis:document.

In the current version I can't get document's parent.

Regards,

> Implement getObjectParents method
> ---------------------------------
>
>                 Key: CMIS-256
>                 URL: https://issues.apache.org/jira/browse/CMIS-256
>             Project: Chemistry
>          Issue Type: Improvement
>          Components: cmislib
>            Reporter: Manuel Jesús Recena Soto
>
> This method is very useful for building breadcrumbs.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CMIS-256) Implement getObjectParents method

Posted by "Florent Guillaume (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CMIS-256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12918872#action_12918872 ] 

Florent Guillaume commented on CMIS-256:
----------------------------------------

Thanks for the patch Manuel, some comments:
- getObjectParents should return a list
- could you please add a unit test to src/tests/cmislibtest.py?
- you should in particular check the call of getObjectParents on the root, in which case it returns an empty list because the root has no parent




> Implement getObjectParents method
> ---------------------------------
>
>                 Key: CMIS-256
>                 URL: https://issues.apache.org/jira/browse/CMIS-256
>             Project: Chemistry
>          Issue Type: Improvement
>          Components: cmislib
>            Reporter: Manuel Jesús Recena Soto
>         Attachments: CMIS-256.patch
>
>
> This method is very useful for building breadcrumbs.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CMIS-256) Implement getObjectParents method

Posted by "Manuel Jesús Recena Soto (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CMIS-256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Manuel Jesús Recena Soto updated CMIS-256:
------------------------------------------

    Status: Open  (was: Patch Available)

> Implement getObjectParents method
> ---------------------------------
>
>                 Key: CMIS-256
>                 URL: https://issues.apache.org/jira/browse/CMIS-256
>             Project: Chemistry
>          Issue Type: Improvement
>          Components: cmislib
>            Reporter: Manuel Jesús Recena Soto
>
> This method is very useful for building breadcrumbs.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (CMIS-256) Implement getObjectParents method

Posted by "Florent Guillaume (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CMIS-256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Florent Guillaume reassigned CMIS-256:
--------------------------------------

    Assignee: Jeff Potts

> Implement getObjectParents method
> ---------------------------------
>
>                 Key: CMIS-256
>                 URL: https://issues.apache.org/jira/browse/CMIS-256
>             Project: Chemistry
>          Issue Type: Improvement
>          Components: cmislib
>            Reporter: Manuel Jesús Recena Soto
>            Assignee: Jeff Potts
>         Attachments: CMIS-256.patch, CMIS-256_revised.patch
>
>
> This method is very useful for building breadcrumbs.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CMIS-256) Implement getObjectParents method

Posted by "Florent Guillaume (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CMIS-256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917929#action_12917929 ] 

Florent Guillaume commented on CMIS-256:
----------------------------------------

Note that getParent is a method of folders, a folder always has exactly one parent (except for the root)
The method for objects in general (including documents) is indeed getObjectParents, but I wanted to point out in my comment that it won't do recursion in ancestors, you'll have to loop yourself.


> Implement getObjectParents method
> ---------------------------------
>
>                 Key: CMIS-256
>                 URL: https://issues.apache.org/jira/browse/CMIS-256
>             Project: Chemistry
>          Issue Type: Improvement
>          Components: cmislib
>            Reporter: Manuel Jesús Recena Soto
>
> This method is very useful for building breadcrumbs.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CMIS-256) Implement getObjectParents method

Posted by "Manuel Jesús Recena Soto (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CMIS-256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12918877#action_12918877 ] 

Manuel Jesús Recena Soto commented on CMIS-256:
-----------------------------------------------

Hi Florent:

1) True, I'll modify this
2) Yes, I can do it
3) Yes

But, one question, do you have thought out a new version of this library?

Regards,

> Implement getObjectParents method
> ---------------------------------
>
>                 Key: CMIS-256
>                 URL: https://issues.apache.org/jira/browse/CMIS-256
>             Project: Chemistry
>          Issue Type: Improvement
>          Components: cmislib
>            Reporter: Manuel Jesús Recena Soto
>         Attachments: CMIS-256.patch
>
>
> This method is very useful for building breadcrumbs.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CMIS-256) Implement getObjectParents method

Posted by "Florent Guillaume (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CMIS-256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917908#action_12917908 ] 

Florent Guillaume commented on CMIS-256:
----------------------------------------

If you think that getObjectParents will return an object's parent and parent's parent and parent's parent's parent etc. then you are mistaken.
Per the spec, getObjectParents returns the folder(s) in which an object is directly filed. It will only every return more than one object on multi-filing based repositories, which is not the case of repositories mimicking simple filesystems.


> Implement getObjectParents method
> ---------------------------------
>
>                 Key: CMIS-256
>                 URL: https://issues.apache.org/jira/browse/CMIS-256
>             Project: Chemistry
>          Issue Type: Improvement
>          Components: cmislib
>            Reporter: Manuel Jesús Recena Soto
>
> This method is very useful for building breadcrumbs.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CMIS-256) Implement getObjectParents method

Posted by "Manuel Jesús Recena Soto (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CMIS-256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Manuel Jesús Recena Soto updated CMIS-256:
------------------------------------------

    Attachment: CMIS-256.patch

> Implement getObjectParents method
> ---------------------------------
>
>                 Key: CMIS-256
>                 URL: https://issues.apache.org/jira/browse/CMIS-256
>             Project: Chemistry
>          Issue Type: Improvement
>          Components: cmislib
>            Reporter: Manuel Jesús Recena Soto
>         Attachments: CMIS-256.patch
>
>
> This method is very useful for building breadcrumbs.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (CMIS-256) Implement getObjectParents method

Posted by "Florent Guillaume (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CMIS-256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917908#action_12917908 ] 

Florent Guillaume edited comment on CMIS-256 at 10/5/10 5:08 AM:
-----------------------------------------------------------------

If you think that getObjectParents will return an object's parent and parent's parent and parent's parent's parent etc. then you are mistaken.
Per the spec, getObjectParents returns the folder(s) in which an object is directly filed. It will only ever return more than one object on multi-filing based repositories, which is not the case of repositories mimicking simple filesystems.


      was (Author: fguillaume):
    If you think that getObjectParents will return an object's parent and parent's parent and parent's parent's parent etc. then you are mistaken.
Per the spec, getObjectParents returns the folder(s) in which an object is directly filed. It will only every return more than one object on multi-filing based repositories, which is not the case of repositories mimicking simple filesystems.

  
> Implement getObjectParents method
> ---------------------------------
>
>                 Key: CMIS-256
>                 URL: https://issues.apache.org/jira/browse/CMIS-256
>             Project: Chemistry
>          Issue Type: Improvement
>          Components: cmislib
>            Reporter: Manuel Jesús Recena Soto
>
> This method is very useful for building breadcrumbs.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CMIS-256) Implement getObjectParents method

Posted by "Manuel Jesús Recena Soto (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CMIS-256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Manuel Jesús Recena Soto updated CMIS-256:
------------------------------------------

    Attachment: CMIS-256_revised.patch

Revised with Florent Guillaume comments:

    * getObjectParents should return a list
    * could you please add a unit test to src/tests/cmislibtest.py?
    * you should in particular check the call of getObjectParents on the root, in which case it returns an empty list because the root has no parent



> Implement getObjectParents method
> ---------------------------------
>
>                 Key: CMIS-256
>                 URL: https://issues.apache.org/jira/browse/CMIS-256
>             Project: Chemistry
>          Issue Type: Improvement
>          Components: cmislib
>            Reporter: Manuel Jesús Recena Soto
>         Attachments: CMIS-256.patch, CMIS-256_revised.patch
>
>
> This method is very useful for building breadcrumbs.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (CMIS-256) Implement getObjectParents method

Posted by "Jeff Potts (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CMIS-256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jeff Potts resolved CMIS-256.
-----------------------------

    Resolution: Fixed

Applied patch and checked in. Thanks for the patch!

> Implement getObjectParents method
> ---------------------------------
>
>                 Key: CMIS-256
>                 URL: https://issues.apache.org/jira/browse/CMIS-256
>             Project: Chemistry
>          Issue Type: Improvement
>          Components: cmislib
>            Reporter: Manuel Jesús Recena Soto
>            Assignee: Jeff Potts
>         Attachments: CMIS-256.patch, CMIS-256_revised.patch
>
>
> This method is very useful for building breadcrumbs.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CMIS-256) Implement getObjectParents method

Posted by "Manuel Jesús Recena Soto (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CMIS-256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Manuel Jesús Recena Soto updated CMIS-256:
------------------------------------------

    Status: Patch Available  (was: Open)

> Implement getObjectParents method
> ---------------------------------
>
>                 Key: CMIS-256
>                 URL: https://issues.apache.org/jira/browse/CMIS-256
>             Project: Chemistry
>          Issue Type: Improvement
>          Components: cmislib
>            Reporter: Manuel Jesús Recena Soto
>
> This method is very useful for building breadcrumbs.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.