You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by jd...@apache.org on 2012/03/21 21:55:18 UTC

svn commit: r1303568 - /lucene/dev/trunk/solr/contrib/dataimporthandler/src/test/org/apache/solr/handler/dataimport/TestScriptTransformer.java

Author: jdyer
Date: Wed Mar 21 20:55:17 2012
New Revision: 1303568

URL: http://svn.apache.org/viewvc?rev=1303568&view=rev
Log:
better messages when ScriptTransform fails on init (add back 1 exception ignore in case JVM doesn't support Rhino)

Modified:
    lucene/dev/trunk/solr/contrib/dataimporthandler/src/test/org/apache/solr/handler/dataimport/TestScriptTransformer.java

Modified: lucene/dev/trunk/solr/contrib/dataimporthandler/src/test/org/apache/solr/handler/dataimport/TestScriptTransformer.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/contrib/dataimporthandler/src/test/org/apache/solr/handler/dataimport/TestScriptTransformer.java?rev=1303568&r1=1303567&r2=1303568&view=diff
==============================================================================
--- lucene/dev/trunk/solr/contrib/dataimporthandler/src/test/org/apache/solr/handler/dataimport/TestScriptTransformer.java (original)
+++ lucene/dev/trunk/solr/contrib/dataimporthandler/src/test/org/apache/solr/handler/dataimport/TestScriptTransformer.java Wed Mar 21 20:55:17 2012
@@ -52,7 +52,9 @@ public class TestScriptTransformer exten
       sep.init(context);
       sep.applyTransformer(map);
       assertEquals(map.get("name"), "Hello Scott");
-    } catch (DataImportHandlerException e) {           
+    } catch (DataImportHandlerException e) {    
+      assumeFalse("This JVM does not have Rhino installed.  Test Skipped.", e
+          .getMessage().startsWith("Cannot load Script Engine for language"));
       throw e;
     }
   }
@@ -98,7 +100,9 @@ public class TestScriptTransformer exten
       config.readFromXml((Element) document.getElementsByTagName("dataConfig")
               .item(0));
       assertTrue(config.script.text.indexOf("checkNextToken") > -1);
-    } catch (DataImportHandlerException e) {
+    } catch (DataImportHandlerException e) {    
+      assumeFalse("This JVM does not have Rhino installed.  Test Skipped.", e
+          .getMessage().startsWith("Cannot load Script Engine for language"));
       throw e;
     }
   }
@@ -125,7 +129,9 @@ public class TestScriptTransformer exten
       map.put("nextToken", "");
       sep.applyTransformer(map);
       assertNull(map.get("$hasMore"));
-    } catch (DataImportHandlerException e) {
+    } catch (DataImportHandlerException e) {    
+      assumeFalse("This JVM does not have Rhino installed.  Test Skipped.", e
+          .getMessage().startsWith("Cannot load Script Engine for language"));
       throw e;
     }
   }