You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/02/09 12:07:05 UTC
[GitHub] [cloudstack] shwstppr opened a new pull request #4385: vmware: vm migration improvements
shwstppr opened a new pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385
## Description
- Fixes inter-cluster migration of VMs
- Allows migration of stopped VM with disks attached to different and suitable pools
- Improves inter-cluster detached volume migration
- Allows inter-cluster migration (clusters of same Pod) for system VMs, VRs on VMware
- Allows storage migration for stopped system VMs, VRs on VMware within same Pod if StoragePool cluster scopetype
Linked Primate PR: https://github.com/apache/cloudstack-primate/pull/789 [Changes merged in this PR after new UI merge]
Documentation PR: https://github.com/apache/cloudstack-documentation/pull/170
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
UI and cmk
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4385: [WIP] vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#issuecomment-733483150
<b>Trillian test result (tid-3245)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 30822 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4385-t3245-xenserver-71.zip
Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
Smoke tests completed. 85 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_scale_vm | `Failure` | 10.40 | test_scale_vm.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4385: [WIP] vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#issuecomment-760092960
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2543
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4385: vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#issuecomment-705236308
<b>Trillian test result (tid-2908)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31315 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4385-t2908-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 84 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_hostha_kvm_host_fencing | `Error` | 175.17 | test_hostha_kvm.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on a change in pull request #4385: [WIP] vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#discussion_r537454194
##########
File path: vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java
##########
@@ -2207,4 +2207,36 @@ public static void createBaseFolderInDatastore(DatastoreMO dsMo, VmwareHyperviso
dsMo.makeDirectory(hiddenFolderPath, hyperHost.getHyperHostDatacenter());
}
}
+
+ public static Integer getHostHardwareVersion(VmwareHypervisorHost host) {
+ Integer version = null;
+ HostMO hostMo = new HostMO(host.getContext(), host.getMor());
+ String hostApiVersion = "";
+ try {
+ hostApiVersion = hostMo.getHostAboutInfo().getApiVersion();
+ } catch (Exception ignored) {}
+ if (hostApiVersion == null) {
+ hostApiVersion = "";
+ }
+ if (hostApiVersion.equalsIgnoreCase("7.0")) {
+ version = 17;
+ } else if (hostApiVersion.equalsIgnoreCase("6.7")) {
+ version = 14;
+ } else if (hostApiVersion.equalsIgnoreCase("6.5")) {
+ version = 13;
+ } else if (hostApiVersion.equalsIgnoreCase("6.0")) {
+ version = 11;
+ } else if (hostApiVersion.equalsIgnoreCase("5.5")) {
+ version = 10;
+ } else if (hostApiVersion.equalsIgnoreCase("5.1")) {
+ version = 9;
+ } else if (hostApiVersion.equalsIgnoreCase("5.0")) {
+ version = 8;
+ } else if (hostApiVersion.startsWith("4.")) {
+ version = 7;
+ } else if (hostApiVersion.equalsIgnoreCase("3.5")) {
+ version = 4;
+ }
+ return version;
Review comment:
@sureshanaparti added change here, https://github.com/apache/cloudstack/pull/4385/commits/fa661f3e5fcbc127a700b663a84b774d134f2af1
please check
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4385: vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#issuecomment-721462413
<b>Trillian test result (tid-3124)</b>
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39695 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4385-t3124-vmware-65u2.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Smoke tests completed. 84 look OK, 2 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_03_deploy_and_upgrade_kubernetes_cluster | `Failure` | 772.99 | test_kubernetes_clusters.py
test_02_list_snapshots_with_removed_data_store | `Error` | 17.12 | test_snapshots.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4385: vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#issuecomment-765316664
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4385: [WIP] vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#issuecomment-741047745
<b>Trillian test result (tid-3317)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31482 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4385-t3317-xenserver-71.zip
Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
Smoke tests completed. 85 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_scale_vm | `Failure` | 9.38 | test_scale_vm.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4385: [WIP] vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#issuecomment-742272455
@shwstppr a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4385: vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#issuecomment-720994608
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4385: [WIP] vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#issuecomment-731775199
@blueorangutan test matrix
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4385: [WIP] vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#issuecomment-731186536
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2417
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4385: vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#issuecomment-768277504
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2600
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4385: vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#issuecomment-776432471
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4385: [WIP] vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#issuecomment-731113708
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4385: [WIP] vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#issuecomment-760097582
@borisstoyanov unsupported parameters provided. Supported mgmt server os are: `centos6, centos7, centos8, ubuntu`. Supported hypervisors are: `kvm-centos6, kvm-centos7, kvm-centos8, kvm-ubuntu, xenserver-71, xenserver-65sp1, vmware-67u3, vmware-65u2, vmware-60u2, vmware-55u3, xcpng76, xcpng80, xcpng81, xenserver-74, xcpng74`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4385: [WIP] vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#issuecomment-751980822
Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2517
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4385: vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#issuecomment-704946759
@shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4385: vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#issuecomment-720994962
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on a change in pull request #4385: [WIP] vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#discussion_r527628756
##########
File path: vmware-base/src/main/java/com/cloud/hypervisor/vmware/util/VmwareHelper.java
##########
@@ -744,4 +744,18 @@ public static XMLGregorianCalendar getXMLGregorianCalendar(final Date date, fina
return DatatypeFactory.newInstance().newXMLGregorianCalendar(gregorianCalendar);
}
+ public static HostMO getHostMOFromHostName(final VmwareContext context, final String hostName) {
+ HostMO host = null;
+ if (com.cloud.utils.StringUtils.isNotBlank(hostName) && hostName.contains("@")) {
+ String hostMorInfo = hostName.split("@")[0];
+ if (hostMorInfo.contains(":")) {
+ ManagedObjectReference morHost = new ManagedObjectReference();
+ morHost.setType(hostMorInfo.split(":")[0]);
+ morHost.setValue(hostMorInfo.split(":")[1]);
+ host = new HostMO(context, morHost);
Review comment:
@rhtyd did that at line 751
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4385: vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#issuecomment-704927344
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2144
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4385: [WIP] vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#issuecomment-760073892
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4385: [WIP] vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#issuecomment-731157228
Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2416
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4385: [WIP] vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#issuecomment-739876540
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4385: vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#discussion_r564464767
##########
File path: api/src/main/java/org/apache/cloudstack/api/command/admin/systemvm/MigrateSystemVMCmd.java
##########
@@ -109,15 +122,43 @@ public String getEventDescription() {
@Override
public void execute() {
+ if (getHostId() == null && getStorageId() == null) {
+ throw new InvalidParameterValueException("Either hostId or storageId must be specified");
+ }
- Host destinationHost = _resourceService.getHost(getHostId());
- if (destinationHost == null) {
- throw new InvalidParameterValueException("Unable to find the host to migrate the VM, host id=" + getHostId());
+ if (getHostId() != null && getStorageId() != null) {
+ throw new InvalidParameterValueException("Only one of hostId and storageId can be specified");
+ }
+
+ Host destinationHost = null;
+ if (getHostId() != null) {
+ destinationHost = _resourceService.getHost(getHostId());
+ if (destinationHost == null) {
+ throw new InvalidParameterValueException("Unable to find the host to migrate the VM, host id=" + getHostId());
+ }
+ if (destinationHost.getType() != Host.Type.Routing) {
+ throw new InvalidParameterValueException("The specified host(" + destinationHost.getName() + ") is not suitable to migrate the VM, please specify another one");
+ }
+ CallContext.current().setEventDetails("VM Id: " + getVirtualMachineId() + " to host Id: " + getHostId());
+ }
+
+ // OfflineMigration performed when this parameter is specified
+ StoragePool destStoragePool = null;
+ if (getStorageId() != null) {
+ destStoragePool = _storageService.getStoragePool(getStorageId());
+ if (destStoragePool == null) {
+ throw new InvalidParameterValueException("Unable to find the storage pool to migrate the VM");
+ }
+ CallContext.current().setEventDetails("VM Id: " + getVirtualMachineId() + " to storage pool Id: " + getStorageId());
}
try {
- CallContext.current().setEventDetails("VM Id: " + this._uuidMgr.getUuid(VirtualMachine.class, getVirtualMachineId()) + " to host Id: " + this._uuidMgr.getUuid(Host.class, getHostId()));
//FIXME : Should not be calling UserVmService to migrate all types of VMs - need a generic VM layer
- VirtualMachine migratedVm = _userVmService.migrateVirtualMachine(getVirtualMachineId(), destinationHost);
+ VirtualMachine migratedVm = null;
+ if (getHostId() != null) {
+ migratedVm = _userVmService.migrateVirtualMachineWithVolume(getVirtualMachineId(), destinationHost, new HashMap<String, String>());
+ } else if (getStorageId() != null) {
+ migratedVm = _userVmService.vmStorageMigration(getVirtualMachineId(), destStoragePool);
Review comment:
@shwstppr possible to optimise multiple checks for _getHostId()_ and _getStorageId()_ not null here ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4385: [WIP] vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#issuecomment-753923863
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2522
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4385: [WIP] vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#issuecomment-751996669
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2519
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd closed pull request #4385: vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4385: [WIP] vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#issuecomment-731113155
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4385: [WIP] vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#issuecomment-731132236
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2415
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4385: [WIP] vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#issuecomment-760643040
@shwstppr a Trillian-Jenkins test job (centos7 mgmt + vmware-65u2) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4385: vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#issuecomment-775846695
@blueorangutan test centos7 vmware-67u3
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4385: [WIP] vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#discussion_r528885775
##########
File path: vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java
##########
@@ -2207,4 +2207,36 @@ public static void createBaseFolderInDatastore(DatastoreMO dsMo, VmwareHyperviso
dsMo.makeDirectory(hiddenFolderPath, hyperHost.getHyperHostDatacenter());
}
}
+
+ public static Integer getHostHardwareVersion(VmwareHypervisorHost host) {
+ Integer version = null;
+ HostMO hostMo = new HostMO(host.getContext(), host.getMor());
+ String hostApiVersion = "";
+ try {
+ hostApiVersion = hostMo.getHostAboutInfo().getApiVersion();
+ } catch (Exception ignored) {}
+ if (hostApiVersion == null) {
+ hostApiVersion = "";
+ }
+ if (hostApiVersion.equalsIgnoreCase("7.0")) {
+ version = 17;
+ } else if (hostApiVersion.equalsIgnoreCase("6.7")) {
+ version = 14;
+ } else if (hostApiVersion.equalsIgnoreCase("6.5")) {
+ version = 13;
+ } else if (hostApiVersion.equalsIgnoreCase("6.0")) {
+ version = 11;
+ } else if (hostApiVersion.equalsIgnoreCase("5.5")) {
+ version = 10;
+ } else if (hostApiVersion.equalsIgnoreCase("5.1")) {
+ version = 9;
+ } else if (hostApiVersion.equalsIgnoreCase("5.0")) {
+ version = 8;
+ } else if (hostApiVersion.startsWith("4.")) {
+ version = 7;
+ } else if (hostApiVersion.equalsIgnoreCase("3.5")) {
+ version = 4;
+ }
+ return version;
Review comment:
@shwstppr is it possible move this to a static map with hypervisor version & its hardware version, in this helper class ? so that it will be easy to maintain and access these versions across the VMware resource.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov removed a comment on pull request #4385: [WIP] vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
borisstoyanov removed a comment on pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#issuecomment-760097009
@blueorangutan test centos7 vmware-65
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr closed pull request #4385: [WIP] vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
shwstppr closed pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4385: [WIP] vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#issuecomment-760642900
@blueorangutan test centos7 vmware-65u2
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4385: vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#issuecomment-704165997
Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2122
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4385: [WIP] vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#issuecomment-731775268
@shwstppr a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4385: [WIP] vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#issuecomment-742681570
<b>Trillian test result (tid-3328)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38766 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4385-t3328-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_human_readable_logs.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Smoke tests completed. 84 look OK, 2 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_enableHumanReadableLogs | `Error` | 0.33 | test_human_readable_logs.py
test_03_deploy_and_upgrade_kubernetes_cluster | `Failure` | 778.11 | test_kubernetes_clusters.py
test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 161.50 | test_kubernetes_clusters.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4385: vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#issuecomment-777186407
<b>Trillian test result (tid-3527)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39354 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4385-t3527-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Smoke tests completed. 85 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_03_deploy_and_upgrade_kubernetes_cluster | `Failure` | 797.16 | test_kubernetes_clusters.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on a change in pull request #4385: [WIP] vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#discussion_r527630615
##########
File path: vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java
##########
@@ -2207,4 +2208,44 @@ public static void createBaseFolderInDatastore(DatastoreMO dsMo, VmwareHyperviso
dsMo.makeDirectory(hiddenFolderPath, hyperHost.getHyperHostDatacenter());
}
}
+
+ public static Integer getHostHardwareVersion(VmwareHypervisorHost host) {
+ Integer version = null;
+ HostMO hostMo = new HostMO(host.getContext(), host.getMor());
+ ComputeResourceConfigInfo info = null;
+ try {
+ info = hostMo.getHostConfigInfo();
+ } catch (Exception ignored) {}
+ if (info != null) {
+ version = Integer.valueOf(info.getDefaultHardwareVersionKey());
+ } else {
+ String hostApiVersion = "";
+ try {
+ hostApiVersion = hostMo.getHostAboutInfo().getApiVersion();
+ } catch (Exception ignored) {}
+ if (hostApiVersion == null) {
+ hostApiVersion = "";
+ }
+ if (hostApiVersion.equalsIgnoreCase("7.0")) {
+ version = 17;
+ } else if (hostApiVersion.equalsIgnoreCase("6.7")) {
+ version = 14;
+ } else if (hostApiVersion.equalsIgnoreCase("6.5")) {
+ version = 13;
+ } else if (hostApiVersion.equalsIgnoreCase("6.0")) {
+ version = 11;
+ } else if (hostApiVersion.equalsIgnoreCase("5.5")) {
+ version = 10;
+ } else if (hostApiVersion.equalsIgnoreCase("5.1")) {
+ version = 9;
+ } else if (hostApiVersion.equalsIgnoreCase("5.0")) {
+ version = 8;
+ } else if (hostApiVersion.startsWith("4.")) {
+ version = 7;
+ } else if (hostApiVersion.equalsIgnoreCase("3.5")) {
Review comment:
@nvazquez @rhtyd @sureshanaparti can you please comment if this is okay. As per our interactions, I tried to get host harwdwareVersion using SDK but it still returns null. By default, VMware is creating VM with highest available hardwareVersion which creates an issue while migrating detached disks across cluster
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4385: [WIP] vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#issuecomment-758576427
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4385: [WIP] vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#issuecomment-739877161
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4385: [WIP] vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#issuecomment-740578423
@shwstppr a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4385: [WIP] vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#issuecomment-733493875
<b>Trillian test result (tid-3246)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32092 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4385-t3246-kvm-centos7.zip
Smoke tests completed. 86 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4385: [WIP] vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#issuecomment-758575892
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4385: [WIP] vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#issuecomment-742272109
@blueorangutan test centos7 vmware-67u3
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4385: vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#issuecomment-704150130
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4385: vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#issuecomment-704150749
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on a change in pull request #4385: [WIP] vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#discussion_r530189204
##########
File path: vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java
##########
@@ -2207,4 +2207,36 @@ public static void createBaseFolderInDatastore(DatastoreMO dsMo, VmwareHyperviso
dsMo.makeDirectory(hiddenFolderPath, hyperHost.getHyperHostDatacenter());
}
}
+
+ public static Integer getHostHardwareVersion(VmwareHypervisorHost host) {
+ Integer version = null;
+ HostMO hostMo = new HostMO(host.getContext(), host.getMor());
+ String hostApiVersion = "";
+ try {
+ hostApiVersion = hostMo.getHostAboutInfo().getApiVersion();
+ } catch (Exception ignored) {}
+ if (hostApiVersion == null) {
+ hostApiVersion = "";
+ }
+ if (hostApiVersion.equalsIgnoreCase("7.0")) {
+ version = 17;
+ } else if (hostApiVersion.equalsIgnoreCase("6.7")) {
+ version = 14;
+ } else if (hostApiVersion.equalsIgnoreCase("6.5")) {
+ version = 13;
+ } else if (hostApiVersion.equalsIgnoreCase("6.0")) {
+ version = 11;
+ } else if (hostApiVersion.equalsIgnoreCase("5.5")) {
+ version = 10;
+ } else if (hostApiVersion.equalsIgnoreCase("5.1")) {
+ version = 9;
+ } else if (hostApiVersion.equalsIgnoreCase("5.0")) {
+ version = 8;
+ } else if (hostApiVersion.startsWith("4.")) {
+ version = 7;
+ } else if (hostApiVersion.equalsIgnoreCase("3.5")) {
+ version = 4;
+ }
+ return version;
Review comment:
@sureshanaparti will look into that
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4385: vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#issuecomment-765375375
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2573
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4385: [WIP] vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#issuecomment-758595094
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2533
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4385: [WIP] vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#issuecomment-741042167
<b>Trillian test result (tid-3318)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31035 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4385-t3318-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_human_readable_logs.py
Smoke tests completed. 85 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_enableHumanReadableLogs | `Error` | 0.33 | test_human_readable_logs.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #4385: vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#issuecomment-721132422
@blueorangutan test matrix
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #4385: [WIP] vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#issuecomment-760073211
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4385: vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#issuecomment-776940022
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4385: vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#issuecomment-777233598
<b>Trillian test result (tid-3530)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39887 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4385-t3530-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 86 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4385: [WIP] vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#issuecomment-761201133
<b>Trillian test result (tid-3384)</b>
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37087 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4385-t3384-vmware-65u2.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Smoke tests completed. 85 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_03_deploy_and_upgrade_kubernetes_cluster | `Failure` | 778.99 | test_kubernetes_clusters.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4385: [WIP] vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#issuecomment-733544045
<b>Trillian test result (tid-3247)</b>
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39352 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4385-t3247-vmware-65u2.zip
Intermittent failure detected: /marvin/tests/smoke/test_human_readable_logs.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Smoke tests completed. 85 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_03_deploy_and_upgrade_kubernetes_cluster | `Failure` | 773.12 | test_kubernetes_clusters.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4385: [WIP] vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#issuecomment-739894675
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2464
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4385: vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#issuecomment-776830221
@blueorangutan test centos7 vmware-67u3
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4385: vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#issuecomment-704946173
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4385: [WIP] vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#issuecomment-760812179
@blueorangutan test centos7 vmware-65u2
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4385: vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#issuecomment-775847158
@shwstppr a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4385: vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#issuecomment-776432291
packages for last test run were not having fix - https://github.com/apache/cloudstack/commit/c9c1d4a6e58739af92639253f5c3c09aecec0468, hence change offering test failed
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #4385: [WIP] vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#issuecomment-760097009
@blueorangutan test centos7 vmware-65
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4385: vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#issuecomment-772263139
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4385: [WIP] vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#issuecomment-760097582
@borisstoyanov unsupported parameters provided. Supported mgmt server os are: `centos6, centos7, centos8, ubuntu`. Supported hypervisors are: `kvm-centos6, kvm-centos7, kvm-centos8, kvm-ubuntu, xenserver-71, xenserver-65sp1, vmware-67u3, vmware-65u2, vmware-60u2, vmware-55u3, xcpng76, xcpng80, xcpng81, xenserver-74, xcpng74`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4385: [WIP] vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#issuecomment-760814111
@shwstppr a Trillian-Jenkins test job (centos7 mgmt + vmware-65u2) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4385: [WIP] vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#issuecomment-760098162
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + vmware-65u2) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #4385: [WIP] vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#issuecomment-760097790
@blueorangutan test centos7 vmware-65u2
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4385: vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#issuecomment-776453977
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2668
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr closed pull request #4385: [WIP] vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
shwstppr closed pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4385: [WIP] vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#issuecomment-733224976
@blueorangutan test matrix
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4385: [WIP] vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#issuecomment-733225546
@shwstppr a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #4385: [WIP] vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#discussion_r520461697
##########
File path: vmware-base/src/main/java/com/cloud/hypervisor/vmware/util/VmwareHelper.java
##########
@@ -744,4 +744,18 @@ public static XMLGregorianCalendar getXMLGregorianCalendar(final Date date, fina
return DatatypeFactory.newInstance().newXMLGregorianCalendar(gregorianCalendar);
}
+ public static HostMO getHostMOFromHostName(final VmwareContext context, final String hostName) {
+ HostMO host = null;
+ if (com.cloud.utils.StringUtils.isNotBlank(hostName) && hostName.contains("@")) {
+ String hostMorInfo = hostName.split("@")[0];
+ if (hostMorInfo.contains(":")) {
+ ManagedObjectReference morHost = new ManagedObjectReference();
+ morHost.setType(hostMorInfo.split(":")[0]);
+ morHost.setValue(hostMorInfo.split(":")[1]);
+ host = new HostMO(context, morHost);
Review comment:
check that split has two length
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4385: vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#issuecomment-776940512
@shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr closed pull request #4385: vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
shwstppr closed pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4385: vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#issuecomment-772262515
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4385: [WIP] vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#issuecomment-741263410
<b>Trillian test result (tid-3319)</b>
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40879 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4385-t3319-vmware-65u2.zip
Intermittent failure detected: /marvin/tests/smoke/test_human_readable_logs.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Smoke tests completed. 83 look OK, 3 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_enableHumanReadableLogs | `Error` | 0.35 | test_human_readable_logs.py
test_03_deploy_and_upgrade_kubernetes_cluster | `Failure` | 790.77 | test_kubernetes_clusters.py
test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 47.78 | test_host_maintenance.py
test_03_cancel_host_maintenace_with_migration_jobs_failure | `Failure` | 42.65 | test_host_maintenance.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4385: [WIP] vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#issuecomment-740577944
@blueorangutan test matrix
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4385: vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#issuecomment-772290799
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2642
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4385: [WIP] vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#discussion_r528885775
##########
File path: vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java
##########
@@ -2207,4 +2207,36 @@ public static void createBaseFolderInDatastore(DatastoreMO dsMo, VmwareHyperviso
dsMo.makeDirectory(hiddenFolderPath, hyperHost.getHyperHostDatacenter());
}
}
+
+ public static Integer getHostHardwareVersion(VmwareHypervisorHost host) {
+ Integer version = null;
+ HostMO hostMo = new HostMO(host.getContext(), host.getMor());
+ String hostApiVersion = "";
+ try {
+ hostApiVersion = hostMo.getHostAboutInfo().getApiVersion();
+ } catch (Exception ignored) {}
+ if (hostApiVersion == null) {
+ hostApiVersion = "";
+ }
+ if (hostApiVersion.equalsIgnoreCase("7.0")) {
+ version = 17;
+ } else if (hostApiVersion.equalsIgnoreCase("6.7")) {
+ version = 14;
+ } else if (hostApiVersion.equalsIgnoreCase("6.5")) {
+ version = 13;
+ } else if (hostApiVersion.equalsIgnoreCase("6.0")) {
+ version = 11;
+ } else if (hostApiVersion.equalsIgnoreCase("5.5")) {
+ version = 10;
+ } else if (hostApiVersion.equalsIgnoreCase("5.1")) {
+ version = 9;
+ } else if (hostApiVersion.equalsIgnoreCase("5.0")) {
+ version = 8;
+ } else if (hostApiVersion.startsWith("4.")) {
+ version = 7;
+ } else if (hostApiVersion.equalsIgnoreCase("3.5")) {
+ version = 4;
+ }
+ return version;
Review comment:
@shwstppr is it possible move this to a static map with hypervisor version & its hardware version, in VMware helper class ? so that it will be easy to maintain and access these versions across the VMware resource.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4385: vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#issuecomment-765316108
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4385: vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#issuecomment-776274122
<b>Trillian test result (tid-3516)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38875 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4385-t3516-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
Smoke tests completed. 84 look OK, 2 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_03_deploy_and_upgrade_kubernetes_cluster | `Failure` | 784.06 | test_kubernetes_clusters.py
test_04_change_offering_small | `Error` | 5.29 | test_service_offerings.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4385: vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4385: vmware: vm migration improvements
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4385:
URL: https://github.com/apache/cloudstack/pull/4385#issuecomment-776831260
@shwstppr a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org